Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Properly reset suspended and skipped nodes when retrying #9422

Merged
merged 6 commits into from
Aug 25, 2022

Conversation

terrytangyuan
Copy link
Member

Issues that we are fixing in this PR:

  • The skipped nodes need to be kept as skipped. Otherwise, the workflow will be stuck on running.
  • The previously supplied parameters needed to be reset for suspended nodes. Otherwise, argo node reset would not work as expected.

Signed-off-by: Yuan Tang terrytangyuan@gmail.com

Signed-off-by: Yuan Tang <terrytangyuan@gmail.com>
Signed-off-by: Yuan Tang <terrytangyuan@gmail.com>
Signed-off-by: Yuan Tang <terrytangyuan@gmail.com>
Signed-off-by: Yuan Tang <terrytangyuan@gmail.com>
Signed-off-by: Yuan Tang <terrytangyuan@gmail.com>
Signed-off-by: Yuan Tang <terrytangyuan@gmail.com>
@terrytangyuan terrytangyuan merged commit 04d1943 into argoproj:master Aug 25, 2022
@terrytangyuan terrytangyuan deleted the fix-suspend-retry branch August 25, 2022 15:03
juchaosong pushed a commit to juchaosong/argo-workflows that referenced this pull request Nov 3, 2022
…oj#9422)

* chore: wip

Signed-off-by: Yuan Tang <terrytangyuan@gmail.com>

* chore: wip

Signed-off-by: Yuan Tang <terrytangyuan@gmail.com>

* chore: clean up

Signed-off-by: Yuan Tang <terrytangyuan@gmail.com>

* chore: clean up

Signed-off-by: Yuan Tang <terrytangyuan@gmail.com>

* chore: Add test

Signed-off-by: Yuan Tang <terrytangyuan@gmail.com>

* chore: fix

Signed-off-by: Yuan Tang <terrytangyuan@gmail.com>

Signed-off-by: Yuan Tang <terrytangyuan@gmail.com>
Signed-off-by: juchao <juchao@coscene.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants