Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(deps): bump argo-events to 1.7.2 #9624

Merged
merged 6 commits into from
Sep 28, 2022
Merged

chore(deps): bump argo-events to 1.7.2 #9624

merged 6 commits into from
Sep 28, 2022

Conversation

blkperl
Copy link
Contributor

@blkperl blkperl commented Sep 20, 2022 •
edited
Loading

fixes #9618

Signed-off-by: William Van Hevelingen william.vanhevelingen@acquia.com

@blkperl
chore(deps): bump argo-events to 1.7.2
d7939fc 
fixes argoproj#9618

Signed-off-by: William Van Hevelingen <william.vanhevelingen@acquia.com>
@blkperl blkperl mentioned this pull request Sep 20, 2022
Closed
@blkperl
chore(deps): Run make pre-commit -B
b6e486a 
Signed-off-by: William Van Hevelingen <william.vanhevelingen@acquia.com>
@blkperl
Copy link
Contributor Author

blkperl commented Sep 21, 2022

Hey @terrytangyuan, any suggestions to getting this passing? make pre-commit -B won't fully complete for me on this PR. I opened #9639 to get lint working for me. make pre-commit -B updated my golang to 1.19 and it doesn't seem to work well with the current version of golangci. However, with that merged locally I still can't make pre-commit -B to finish

@terrytangyuan
Copy link
Member

Pull changes from #9639?

@blkperl
Merge branch 'master' into issue_9618
1b4447b 
Signed-off-by: William Van Hevelingen <william.vanhevelingen@acquia.com>
@blkperl
Copy link
Contributor Author

blkperl commented Sep 26, 2022

@terrytangyuan any idea on how to fix the codegen test?

@terrytangyuan
Copy link
Member

Did you run make codegen -B STATIC_FILES=false?

@blkperl
Copy link
Contributor Author

blkperl commented Sep 27, 2022

@terrytangyuan I tried it and nothing changed. I think it runs as part of make pre-commit -B anyways.

@terrytangyuan
Copy link
Member

The diff came from pkg/client/clientset/ so I think you have different versions of the toolchain from what we have in the CI. I'd double check the versions in the logs: https://github.com/argoproj/argo-workflows/actions/runs/3122754914/jobs/5064938383

@terrytangyuan terrytangyuan merged commit 4e34979 into argoproj:master Sep 28, 2022
@blkperl blkperl deleted the issue_9618 branch September 28, 2022 15:04
chenyangxueHDU pushed a commit to chenyangxueHDU/argo that referenced this pull request Sep 29, 2022
@blkperl
chore(deps): bump argo-events to 1.7.2 (argoproj#9624)
785e339 
Signed-off-by: yangxue.chen <chenyangxuehdu@126.com>
juchaosong pushed a commit to juchaosong/argo-workflows that referenced this pull request Nov 3, 2022
@blkperl @juchaosong
chore(deps): bump argo-events to 1.7.2 (argoproj#9624)
dcb2247 
Signed-off-by: juchao <juchao@coscene.io>
@agilgur5 agilgur5 added type/dependencies PRs and issues specific to updating dependencies go Pull requests that update Go dependencies area/build Build or GithubAction/CI issues labels Jan 19, 2024
@agilgur5 agilgur5 mentioned this pull request Jan 19, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@terrytangyuan terrytangyuan terrytangyuan approved these changes

Assignees
No one assigned
Labels
area/build Build or GithubAction/CI issues go Pull requests that update Go dependencies type/dependencies PRs and issues specific to updating dependencies
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Upgrade argo-cli to use argo-events >= 1.7.1
3 participants
@blkperl @terrytangyuan @agilgur5