fix: Fixed artifact retrieval when templateRef in use. Fixes #9631, #9644. #9648
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…#9631. Signed-off-by: Brian Loss <brianloss@gmail.com>
juliev0
reviewed
Sep 21, 2022
* Expose getTemplateFromNode in workflow/util/util.go * Update uses of getTemplateFromNode to GetTemplateFromNode * Call GetTemplateFromNode in artifact_server.go Signed-off-by: Brian Loss <brianloss@gmail.com>
brianloss
changed the title
Closed
3 tasks
juliev0
approved these changes
Sep 21, 2022
terrytangyuan
approved these changes
Sep 21, 2022
|
@juliev0 or @terrytangyuan, do I need to do anything else to help get this fix gets into the next 3.4.x release? I wasn't sure since this went to master and there's a release-3.4 branch. |
|
@sarabala1979 Could we cherry-pick this? |
juchaosong
pushed a commit
to juchaosong/argo-workflows
that referenced
this pull request
Nov 3, 2022
…#9631, argoproj#9644. (argoproj#9648) * fix: Fixed artifact retrieval when templateRef in use. Fixes argoproj#9631. Signed-off-by: Brian Loss <brianloss@gmail.com> * chore: Address review feedback - use util method * Expose getTemplateFromNode in workflow/util/util.go * Update uses of getTemplateFromNode to GetTemplateFromNode * Call GetTemplateFromNode in artifact_server.go Signed-off-by: Brian Loss <brianloss@gmail.com> Signed-off-by: Brian Loss <brianloss@gmail.com> Signed-off-by: juchao <juchao@coscene.io>
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Handle artifact retrieval when the workflow node has no templateName set but
does have templateRef set instead. Added a unit test that was broken before
the changes and works after the changes.
Fixes #9631, Fixes #9644
Signed-off-by: Brian Loss brianloss@gmail.com