fix: retry ExecutorPlugin invocation on transient network errors Fixes: #9664 #9665
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Suckzoo
changed the title
|
@terrytangyuan Thanks for pointing out. I wrote that function while I was investigating the problem(with some extra logs). Merged them into |
Signed-off-by: Seokju Hong <seokju@vessl.ai>
Signed-off-by: Seokju Hong <seokju@vessl.ai>
Signed-off-by: Seokju Hong <seokju@vessl.ai>
terrytangyuan
approved these changes
Sep 27, 2022
This was referenced Sep 27, 2022
chenyangxueHDU
pushed a commit
to chenyangxueHDU/argo
that referenced
this pull request
Sep 29, 2022
argoproj#9664 (argoproj#9665) Signed-off-by: yangxue.chen <chenyangxuehdu@126.com>
juchaosong
pushed a commit
to juchaosong/argo-workflows
that referenced
this pull request
Nov 3, 2022
argoproj#9664 (argoproj#9665) Signed-off-by: juchao <juchao@coscene.io>
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #9664
Say how you tested your changes. If you changed the UI, attach screenshots.
util/errors/errors_test.go: tests *url.Error also can be a transient network error.