fix: enable when expressions to use expr; add new json variables to avoid expr conflicts

[juliev0]

Fixes #8911
Fixes #9742

This removes the validation check which prevents expr from being used in a "when" condition, which had gotten added here.

Apparently, the actual problem that was being addressed there was the fact that "workflow.parameters" couldn't be used in an expr expression. The issue was that there were conflicts since both "workflow.parameters" and "workflow.parameters.x" were variables that need replacing, and the call to evaluate expr can't handle cases in which one variable is a prefix of another. Therefore, this adds a new variable "workflow.parameters.json" which is equivalent to "workflow.parameters". "workflow.parameters" should eventually be phased out in favor of this. (For now, we can keep it: it's just that it can't be handled in an expr expression.)

[juliev0]

had to change the whalesay image to argosay image since apparently whalesay isn't supposed to be used for e2e tests

[juliev0]

removed the dash from the name since expr expressions which include dash need to be formatted with brackets due to the special character

[terrytangyuan]

@juliev0 You need to fix your fork. :-) So many dependabot commits.

[juliev0]

@juliev0 You need to fix your fork. :-) So many dependabot commits.

Thanks for noticing that. I need to be better about keeping my fork up to date. I'll create a new PR for this.

[alexec]

dupe

[juliev0]

@alexec why did you close this? Dupe of what?

[juliev0]

@alexec why did you close this? Dupe of what?

oh, sorry. I see - I shouldn't try to respond to comments from my phone :)

[agilgur5]

Replaced by #9761