fix: upgrade python openapiclient version, fixes #9770 #9840
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tianchu Zhao <evantczhao@gmail.com>
Signed-off-by: Tianchu Zhao <evantczhao@gmail.com>
tczhao
changed the title
There was a problem hiding this comment.
We may have a hard requirement on lower versions of the generator to work around a particular issue.
@flaviuvadan Could you help double-check?
Comment on lines
+177
to
+178
| docker pull openapitools/openapi-generator-cli:v5.4.0 & | ||
| docker pull openapitools/openapi-generator-cli:v5.2.1 & |
There was a problem hiding this comment.
Why are we pulling two versions?
There was a problem hiding this comment.
The python gen is upgraded to v5.4.0
Java gen is facing some issues in v5.4.0, unchanged for now, remain at 5.2.1
|
The Java version is having issues with |
alexec
approved these changes
Oct 18, 2022
|
Reviewed for the objects used by Hera and, from my perspective, most changes are of this kind: LGTM |
flaviuvadan
approved these changes
Oct 21, 2022
juchaosong
pushed a commit
to juchaosong/argo-workflows
that referenced
this pull request
Nov 3, 2022
…roj#9840) Signed-off-by: Tianchu Zhao <evantczhao@gmail.com> Signed-off-by: juchao <juchao@coscene.io>
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9770
related commit in openapi client cli
OpenAPITools/openapi-generator#11234
Had attempted to align the openapi version for java to the same as python
but meeting errors.
I'm extremely raw in java, would take quite some time to understand what's happening.
Maybe we can create an issue for that once this merged
Please do not open a pull request until you have checked ALL of these:
make pre-commit -Bto fix codegen and lint problems.If changes were requested, and you've made them, dismiss the review to get it reviewed again.