fix: Child apps should not affect parent app's health by default #153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Keith Chong <kykchong@redhat.com>
|
Kudos, SonarCloud Quality Gate passed!
|
Codecov Report
@@ Coverage Diff @@
## master #153 +/- ##
==========================================
- Coverage 54.07% 53.98% -0.10%
==========================================
Files 25 25
Lines 2415 2410 -5
==========================================
- Hits 1306 1301 -5
Misses 974 974
Partials 135 135
Continue to review full report at Codecov.
|
|
@alexmt , please review |
Closed
7 tasks
trown
added a commit
to trown/gitops-engine
that referenced
this pull request
Dec 9, 2020
…ult (argoproj#153)" This reverts commit 3a3f6a3. Conflicts: pkg/health/health.go
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Keith Chong kykchong@redhat.com
This fix is for ArgoCD issue: argoproj/argo-cd#3781
Remove health assessment check for applications