feat: add annotation to the custom namesapce #440
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #440 +/- ##
==========================================
+ Coverage 55.22% 55.31% +0.08%
==========================================
Files 41 41
Lines 4449 4460 +11
==========================================
+ Hits 2457 2467 +10
- Misses 1803 1804 +1
Partials 189 189
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
ashutosh16
force-pushed
the
feat/customnamespace-annotation
branch
from
3c02a28 to
e3bbd67
Compare
crenshaw-dev
requested changes
Aug 10, 2022
ashutosh16
force-pushed
the
feat/customnamespace-annotation
branch
2 times, most recently
from
ea7adb4 to
d251af9
Compare
crenshaw-dev
requested changes
Aug 11, 2022
ashutosh16
force-pushed
the
feat/customnamespace-annotation
branch
from
fd3885f to
8884c21
Compare
Signed-off-by: Ashutosh <mail.ashutosh8@gmail.com>
Signed-off-by: Ashutosh <mail.ashutosh8@gmail.com>
ashutosh16
force-pushed
the
feat/customnamespace-annotation
branch
from
8884c21 to
f62fe65
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
|
Not require |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support annotation and labels for custom namespace.
This is a prerequisite for fixing argoproj/argo-cd#4628
This Argocd PR depends on this change
Signed-off-by: Ashutosh mail.ashutosh8@gmail.com