feat: retry with client side dry run if server one was failed #548
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: pashakostohrys <pavel@codefresh.io>
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #548 +/- ##
==========================================
- Coverage 54.70% 54.65% -0.05%
==========================================
Files 41 41
Lines 4645 4647 +2
==========================================
- Hits 2541 2540 -1
- Misses 1908 1910 +2
- Partials 196 197 +1
☔ View full report in Codecov by Sentry. |
|
Tested with 1.24 and 1.25 cluster |
Signed-off-by: pashakostohrys <pavel@codefresh.io>
…' into feat/server-side-dry-run-fallback # Conflicts: # pkg/sync/sync_context.go
Signed-off-by: pashakostohrys <pavel@codefresh.io>
|
Kudos, SonarCloud Quality Gate passed!
|
crenshaw-dev
approved these changes
Nov 2, 2023
3 tasks
anandf
added a commit
to anandf/gitops-engine
that referenced
this pull request
Jan 19, 2024
…argoproj#548)" This reverts commit c0c2dd1.
anandf
added a commit
to anandf/gitops-engine
that referenced
this pull request
Jan 19, 2024
…argoproj#548)" This reverts commit c0c2dd1. Signed-off-by: Anand Francis Joseph <anjoseph@redhat.com>
leoluz
added a commit
that referenced
this pull request
Jan 22, 2024
…idation even with server side apply (#564) * Revert "feat: retry with client side dry run if server one was failed (#548)" This reverts commit c0c2dd1. Signed-off-by: Anand Francis Joseph <anjoseph@redhat.com> * Revert "fix(server): use server side dry run in case if it is server side apply (#546)" This reverts commit 4a5648e. Signed-off-by: Anand Francis Joseph <anjoseph@redhat.com> * Fixed the logic to disable server side apply if it is a dry run Signed-off-by: Anand Francis Joseph <anjoseph@redhat.com> * Added more values in the log message for better debugging Signed-off-by: Anand Francis Joseph <anjoseph@redhat.com> * Fixed compilation error Signed-off-by: Anand Francis Joseph <anjoseph@redhat.com> * Written an inline fn to get string value of dry-run strategy Signed-off-by: Anand Francis Joseph <anjoseph@redhat.com> * Added comment as requested with reference to the issue number Signed-off-by: Anand Francis Joseph <anjoseph@redhat.com> --------- Signed-off-by: Anand Francis Joseph <anjoseph@redhat.com> Co-authored-by: Leonardo Luz Almeida <leoluz@users.noreply.github.com>
nerdeveloper
pushed a commit
to nerdeveloper/gitops-engine
that referenced
this pull request
May 13, 2024
…oj#548) * feat: retry with client side dry run if server one was failed Signed-off-by: pashakostohrys <pavel@codefresh.io> * feat: retry with client side dry run if server one was failed Signed-off-by: pashakostohrys <pavel@codefresh.io> * feat: retry with client side dry run if server one was failed Signed-off-by: pashakostohrys <pavel@codefresh.io> --------- Signed-off-by: pashakostohrys <pavel@codefresh.io> Signed-off-by: Obinna Odirionye <odirionye@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes for #547
Closes: argoproj/argo-cd#16177