Update condition to select right pvc as child for statefulset #550
Conversation
Signed-off-by: hanzala <muhammad.hanzala@waltlabs.io>
hanzala1234
force-pushed
the
fix-sts-child-condition
branch
from
e08484a to
eed5eb7
Compare
Signed-off-by: hanzala <muhammad.hanzala@waltlabs.io>
hanzala1234
force-pushed
the
fix-sts-child-condition
branch
from
4d3abf0 to
34bc0f0
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
hanzala1234
changed the title
hanzala1234
changed the title
|
Any updates on this, I've experienced this issue as well and it would be nice to get it resolved. |
|
any update on this issue? |
|
any update on this? It's a bug fix and its been open for over 4 months |
|
@hanzala1234 thank you for your contribution. Could you please cover your changes with tests and also could you please add example yamls so i can test the fix locally? |
|
i know @hanzala1234 did the work along with my company, I can try to take a look at that. I should have time this week (I'm gonna be traveling tomorrow). |
|
Thank you @bradenwright |
|
I've had a few fires pop up this week, so it will probably be a week or 2 til I have time to look into this. |
test(cache): Add tests for isStatefulSetChild function
|
|
Hello @pasha-codefresh We have added some test cases/examples into the code, it is good to review now |
|
Just another reminder that need to be checked please @pasha-codefresh |
|
@nerdeveloper will review it tomorrow, sorry, didnt notice your msg |
|
Looks great for me, just doing manual testing and will merge it |
Issue is resolved, LGTM! |
|
@hanzala1234 , thank you for your contribution, feel free to open ArgoCD PR with gitops-engine version update, you can assign or tag me, i will review it |
|
thanks @pasha-codefresh for merging MR. I will work on it tomorrow |
…oj#550) * Update if condition to select right pvc as child for statefulset Signed-off-by: hanzala <muhammad.hanzala@waltlabs.io> * fix indentation Signed-off-by: hanzala <muhammad.hanzala@waltlabs.io> * test(cache): Add tests for isStatefulSetChild function * test(pkg/cache): Replace JSON unmarshalling with structured approach in tests --------- Signed-off-by: hanzala <muhammad.hanzala@waltlabs.io> Co-authored-by: hanzala <muhammad.hanzala@waltlabs.io> Co-authored-by: Obinna Odirionye <odirionye@gmail.com>
We have 2 pvc in namespace, one with name
emqx-data-sw-broker-0for statefulsetsw-brokerand other one isemqx-data-sw-broker-internal-0for statefulsetsw-broker-internaland both have same template nameemqx-data. sinceemqx-data-sw-broker-internal-0contains prefixemqx-data-sw-broker-, it consider it as part of sw-broker statefulset which is not right. fixing condition to check if it contains number at the end of prefix