Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jest-dev-server - "kill" missing in "usedPortAction" type definition #572

Closed
pmrotule opened this issue Dec 5, 2023 · 1 comment · Fixed by #573
Closed

jest-dev-server - "kill" missing in "usedPortAction" type definition #572

pmrotule opened this issue Dec 5, 2023 · 1 comment · Fixed by #573

Comments

@pmrotule
Copy link

pmrotule commented Dec 5, 2023

🐛 Bug Report

In jest-dev-server, the types for the usedPortAction includes kill in the README, but it is not present in the actual type definition which throws a Typescript error:

### `usedPortAction`
Type: `string` (`ask`, `error`, `ignore`, `kill`) default to `ask`.

usedPortAction?: "ask" | "error" | "ignore";

To Reproduce

Steps to reproduce the behavior:

Define the usedPortAction with kill, you'll see the error right away:

image

Expected behavior

No type error

Link to repl or repo (highly encouraged)

N/A

Run npx envinfo --system --binaries --npmPackages expect-puppeteer,jest-dev-server,jest-environment-puppeteer,jest-puppeteer,spawnd --markdown --clipboard

Paste the results here:

## System:
 - OS: macOS 13.5.1
 - CPU: (10) arm64 Apple M1 Pro
 - Memory: 69.36 MB / 16.00 GB
 - Shell: 5.9 - /bin/zsh
## Binaries:
 - Node: 18.18.2 - ~/.nvm/versions/node/v18.18.2/bin/node
 - Yarn: 1.22.19 - ~/.yarn/bin/yarn
 - npm: 9.8.1 - ~/.nvm/versions/node/v18.18.2/bin/npm
 - pnpm: 8.7.4 - ~/Library/pnpm/pnpm
 - bun: 1.0.0 - ~/.bun/bin/bun
@gregberge
Copy link
Member

Thanks, it is fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants