Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(jest-environment-puppeteer): added config option for global err msg #35

Merged
merged 2 commits into from
Apr 11, 2018
Merged

feat(jest-environment-puppeteer): added config option for global err msg #35

merged 2 commits into from
Apr 11, 2018

Conversation

kaufmann42
Copy link
Contributor

Closes #34

@gregberge
Copy link
Member

Thanks, can you default it to true?

@kaufmann42
Copy link
Contributor Author

Will do.

@kaufmann42
Copy link
Contributor Author

Went ahead and added.

@gregberge gregberge merged commit d87c99a into argos-ci:master Apr 11, 2018
@gregberge
Copy link
Member

Thanks!

@kaufmann42 kaufmann42 deleted the global-error-config branch April 11, 2018 17:05
@linusrachlis
Copy link

Hi @neoziro ,

Just curious what's the thinking behind having this default to true. Should any page-level JS error be considered a test failure? Sadly these days, it's a rare website that has no JS errors, and sometimes they are caused by external libraries out of the developer's control. I would have thought the more common case would be that you don't want the browser to exit on a page-level error, although some people might want the option to do so. What do you think?

Thanks,
Linus

@gregberge
Copy link
Member

Hello @linusrachlis, I think it is better to encourage user to not have uncaught errors in console. Anyway now you have the choice but defaulting to true encourages best practice.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make global error handler configurable
3 participants