allow options on rendering centerlines, directly generating mp4, and … #170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…using proper notation for SE(3)
…v2.VideoWriter output
| import numpy as np | ||
|
|
||
| """ | ||
| Python-based utilities to avoid blowing up the disk with images, as FFMPEG requires. |
There was a problem hiding this comment.
There was a problem hiding this comment.
I didn't realize we had this dependency tbh (it's not in our dependency list for some reason), I'll take a look
There was a problem hiding this comment.
What were your thoughts on this?
There was a problem hiding this comment.
haven't played around with moviepy before, but we should check it out more: https://zulko.github.io/moviepy/
janesjanes
approved these changes
Oct 24, 2020
janesjanes
reviewed
Oct 24, 2020
| ) | ||
| for log_id in log_ids | ||
| ] | ||
| with Pool(os.cpu_count()) as p: |
There was a problem hiding this comment.
Since it take awhile to run, would be nice to be able to specify number of cpu to use as well so we can do something else while rendering.
… add-cv2-VideoWriter-support
… add-cv2-VideoWriter-support
|
Do we have any blockers here? |
|
LGTM 👍 |
added 8 commits
May 7, 2021 00:53
… add-cv2-VideoWriter-support
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For
cuboids_to_bboxes.pyscript: