Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Import global constants from config #222

Merged
merged 9 commits into from
May 13, 2021
Merged

Import global constants from config #222

merged 9 commits into from
May 13, 2021

Commits on May 11, 2021

  1. use config values, instead of hard-coded values in camera_stats.py

    John Lambert committed May 11, 2021
    Configuration menu
    Copy the full SHA
    5efb25d View commit details
    Browse the repository at this point in the history

  2. use config values, instead of hard-coded fps vals

    John Lambert committed May 11, 2021
    Configuration menu
    Copy the full SHA
    e77e271 View commit details
    Browse the repository at this point in the history

  3. fix mypy error, by checking if img_width or img_height are None

    John Lambert committed May 11, 2021
    Configuration menu
    Copy the full SHA
    eab0335 View commit details
    Browse the repository at this point in the history

Commits on May 12, 2021

  1. switch to dataclass so that we get __dict__ attribute for class

    John Lambert committed May 12, 2021
    Configuration menu
    Copy the full SHA
    3f402c6 View commit details
    Browse the repository at this point in the history

  2. add omegaconf so we can use MISSING in hydra configs

    John Lambert committed May 12, 2021
    Configuration menu
    Copy the full SHA
    35bdc75 View commit details
    Browse the repository at this point in the history

  3. add a unit test on the config

    John Lambert committed May 12, 2021
    Configuration menu
    Copy the full SHA
    9b27703 View commit details
    Browse the repository at this point in the history

  4. fix docstring

    John Lambert committed May 12, 2021
    Configuration menu
    Copy the full SHA
    e6dfadc View commit details
    Browse the repository at this point in the history

  5. add type hint to global constants, using typing_extensions.Final

    John Lambert committed May 12, 2021
    Configuration menu
    Copy the full SHA
    ad0297f View commit details
    Browse the repository at this point in the history

Commits on May 13, 2021

  1. Merge branch 'master' of https://github.com/argoai/argoverse-api into… 

    … use-global-constants
    John Lambert committed May 13, 2021
    Configuration menu
    Copy the full SHA
    37897b6 View commit details
    Browse the repository at this point in the history