Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Detection eval max boxes fix #227

Merged
merged 12 commits into from
May 28, 2021
Merged

Detection eval max boxes fix #227

merged 12 commits into from
May 28, 2021

Conversation

benjaminrwilson
Copy link
Contributor

This is a followup PR. This adds two small things:

  1. Unit test for rank.
  2. A small revision previously discussed to remove the conditional in rank.

jagjeet-singh
jagjeet-singh suggested changes May 25, 2021
View reviewed changes
Copy link
Contributor

@jagjeet-singh jagjeet-singh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some minor comments

argoverse/utils/transform.py Outdated Show resolved Hide resolved
demo_usage/visualize_30hz_benchmark_data_on_map.py Outdated Show resolved Hide resolved
integration_tests/test_map_api.py Outdated Show resolved Hide resolved
tests/test_manhattan_search.py Outdated Show resolved Hide resolved
tagarwal-argoai
tagarwal-argoai approved these changes May 25, 2021
View reviewed changes
Copy link
Contributor

@tagarwal-argoai tagarwal-argoai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some comments. Let me know what you think.

integration_tests/test_map_api.py Outdated Show resolved Hide resolved
tests/test_eval_detection.py Outdated Show resolved Hide resolved
tests/test_ffmpeg_utils_unit.py Outdated Show resolved Hide resolved
tagarwal-argoai
tagarwal-argoai reviewed May 25, 2021
View reviewed changes
Copy link
Contributor

@tagarwal-argoai tagarwal-argoai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some comments. Let me know what you think.

tagarwal-argoai
tagarwal-argoai reviewed May 25, 2021
View reviewed changes
Copy link
Contributor

@tagarwal-argoai tagarwal-argoai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some comments. Let me know what you think.

johnwlambert
johnwlambert approved these changes May 25, 2021
View reviewed changes
Copy link
Contributor

@johnwlambert johnwlambert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Feel free to merge if CI passes

tagarwal-argoai
tagarwal-argoai approved these changes May 26, 2021
View reviewed changes
Copy link
Contributor

@tagarwal-argoai tagarwal-argoai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@johnwlambert
Copy link
Contributor

@jagjeet-singh could you merge this if it looks OK to you?

@jagjeet-singh jagjeet-singh merged commit 89bc90a into argoverse:master May 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jagjeet-singh jagjeet-singh jagjeet-singh requested changes

@johnwlambert johnwlambert johnwlambert approved these changes

@tagarwal-argoai tagarwal-argoai tagarwal-argoai approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@benjaminrwilson @johnwlambert @jagjeet-singh @tagarwal-argoai