Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add detection eval optimizations. #236

Merged
merged 1 commit into from
Jun 7, 2021
Merged

Add detection eval optimizations. #236

merged 1 commit into from
Jun 7, 2021

Conversation

benjaminrwilson
Copy link
Contributor

Speeds up the multiprocessing in the detection eval + transitions classes to dataclasses

tagarwal-argoai
tagarwal-argoai reviewed Jun 4, 2021
View reviewed changes
Copy link
Contributor

@tagarwal-argoai tagarwal-argoai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of comments here as well.

argoverse/evaluation/detection/eval.py Outdated Show resolved Hide resolved
argoverse/evaluation/detection/utils.py Show resolved Hide resolved
@johnwlambert
Copy link
Contributor

Thanks for the PR, @benjaminrwilson. It looks like CI is failing:

FAILED tests/test_eval_detection.py::test_accumulate - TypeError: accumulate(...
FAILED tests/test_eval_detection.py::test_remove_duplicate_instances_ground_truth
FAILED tests/test_eval_detection.py::test_AP_on_filtered_instances - ValueErr...

Do you mind taking a look?

tagarwal-argoai
tagarwal-argoai approved these changes Jun 7, 2021
View reviewed changes
Copy link
Contributor

@tagarwal-argoai tagarwal-argoai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@benjaminrwilson benjaminrwilson merged commit 4e5f7d5 into argoverse:master Jun 7, 2021
@benjaminrwilson benjaminrwilson deleted the optimize-eval-detection branch June 7, 2021 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tagarwal-argoai tagarwal-argoai tagarwal-argoai approved these changes

@jagjeet-singh jagjeet-singh Awaiting requested review from jagjeet-singh

@wqi wqi Awaiting requested review from wqi

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@benjaminrwilson @johnwlambert @tagarwal-argoai