Skip to content

Commit

Permalink
vim: turnoff vimagit help
Browse files Browse the repository at this point in the history 
it fucks things up
  • Loading branch information
@argshook
argshook committed Feb 24, 2017
1 parent 9492e76 commit d3431ee
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion .argsdotfiles/vim/neobundle.vim
View file
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ NeoBundle 'jreybert/vimagit'
autocmd User VimagitEnterCommit startinsert
autocmd User VimagitBufferInit set foldenable
let g:magit_show_help=0
let g:magit_default_sections = [ 'commit', 'staged', 'unstaged', 'info', 'global_help' ]
let g:magit_default_sections = [ 'commit', 'staged', 'unstaged', 'global_help' ]

NeoBundle 'tpope/vim-obsession'
NeoBundle 'tpope/vim-surround'
Expand Down

4 comments on commit d3431ee

@jreybert
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, what's wrong with it? Could you open an issue please?

@jreybert
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the record, I found your commit through twitter :)

@argshook
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jreybert oh my what an honor! thanks for vimagit man.

issue is most probably related to me having millions of plugins, the way i use folds and how i open magit.

in essence, with the following settings i'm getting errors in :messages and have to press any key everytime i do magit#show_magit('h', 1, 1):

set foldmethod=indent
set foldlevelstart=1
let g:magit_default_sections = [ 'commit', 'staged', 'unstaged', 'info', 'global_help' ]

the error looks somewhat like:

Error detected while processing modelines:
line   34:
"magit:///Users/argshook/"  line 1 of 36 --2%-- col 1
E518: Unknown option: change

the error i wrote above appears when i set info to be last section (when global_help is off). info section in this case looked like this:

Current repository: /Users/argshook/
Current branch:     master
Last commit:        ad04074 vim: change emmet bind to <A-w>

notice the part vim: change and compare to E518: Unknown option: change. Feels like somehow somewhere vim tries to use my commit message as an option for something.

so as quick workaround i just disabled info section in this commit. I can easily go away with it.

I have no idea whether this is an issue with vimagit or my setup, need to spend some time to understand this. don't want to open issues for you without being 100% sure it's not my setup that's broken.

thanks for the plugin again, git workflow is really great with it. there are some annoyances though, but it's impossible to satisfy every user. i should just open PRs instead of complaining (once i know vimscript good enough :) )

@jreybert
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed, it was a bug from vimagit jreybert/vimagit#120

Anyway, you seems to be one of the most advanced user of vimagit I ever met :) You use options I did forgot myself ;)

If you have ideas (or complains), feel free to open PR if you want to contribute, and if you don't have time, open an issue for enhancement, I always need feedback (and advise) from users.

Please sign in to comment.