Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Matrix job to check downstream compiles #88

Closed
samuelburnham opened this issue Jun 25, 2024 · 0 comments · Fixed by #126
Closed

ci: Matrix job to check downstream compiles #88

samuelburnham opened this issue Jun 25, 2024 · 0 comments · Fixed by #126
Assignees

Comments

@samuelburnham
Copy link
Member

After #87 (review)

Each crate has its own dependencies and configuration, which could be handled by a repo-specific setup.yml action. However, in the case of Sphinx and ZKLC, these setup actions are largely redundant, but that can be streamlined by e.g. ZKLC just using the Sphinx setup action since it clones the latter anyway.

Another approach would be passing multiple crates to the check-downstream-compiles action, though it becomes a bit harder to debug if collapsed into a single step.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant