Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Byte record bounds #32

Merged
merged 1 commit into from
Jun 6, 2024
Merged

refactor: Byte record bounds #32

merged 1 commit into from
Jun 6, 2024

Conversation

huitseeker
Copy link
Contributor

A simple initial fragment of decoupling the output from ExecutionRecord.

@huitseeker huitseeker requested a review from adr1anh June 6, 2024 14:07
@huitseeker huitseeker changed the title Byte record bounds refactor: Byte record bounds Jun 6, 2024
- Replaced the specific `ExecutionRecord` argument with the more general `impl ByteRecord` across all `populate` functions, promoting better flexibility.
- Removed unused `ExecutionRecord` imports in various operation implementation files.
@huitseeker huitseeker marked this pull request as ready for review June 6, 2024 14:59
Copy link
Contributor

@adr1anh adr1anh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@huitseeker huitseeker merged commit 3f60558 into dev Jun 6, 2024
6 checks passed
@huitseeker huitseeker deleted the byte_record_bounds branch June 6, 2024 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants