ci: Add release workflow #48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I believe that we should handle the proper versioning of the crates that are meant to be used as dependencies, so I wouldn't add them in my opinion. |
tchataigner
previously approved these changes
Jun 18, 2024
huitseeker
reviewed
Jun 20, 2024
.github/workflows/release-pr.yml
Outdated
| runs-on: ubuntu-latest | ||
| env: | ||
| # Crates from which the version will be bumped | ||
| CRATES: './cli, ./core, ./derive, ./eval, ./helper, ./primitives, ./prover, ./recursion/circuit, ./recursion/compiler, ./recursion/core, ./recursion/gnark-ffi, ./recursion/program, ./sdk, ./tutorials, ./zkvm/entrypoint, ./zkvm/precompiles' |
There was a problem hiding this comment.
This is going to be a pain to maintain.
How about :
- removing the glob in the
membersfield of the[workspace]section in the top-levelCargo.toml, - installing
tomlqin the CI machines using cargo-install, - do something like:
huitseeker@MacBook-Pro.localdomain➜~/tmp/sphinx(dev)» for i in $(tomlq workspace.members -f Cargo.toml|jq -r '.[] | "\"" + . + "\","'); do echo $i; done
"cli",
"core",
"derive",
"eval",
"helper",
"primitives",
"prover",
"recursion/circuit",
"recursion/compiler",
"recursion/core",
"recursion/gnark-ffi",
"recursion/program",
"sdk",
"tutorials",
"zkvm/*",
There was a problem hiding this comment.
Great idea, I used this up to date fork instead: https://github.com/cryptaliagy/tq-rs
samuelburnham
force-pushed
the
ci-release
branch
from
f564136
to
fb020b6
Compare
tchataigner
approved these changes
Jun 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a release workflow based on argumentcomputer/zk-light-clients#19 and argumentcomputer/aptos-core#5
TODO:
Do we also want to bump theCargo.tomls fortests,examples, andcli/src/assets?