Add ntfs special file support, closes #9 #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
... but the code is SHIT
Can't actually remember what triggered this, but we're more const-correct because of it, and use fewer of the evil CDCs.
The problem (I THINK!) was in the VIEW, **NOT** the CONTROL. Hence the extra call to CWnd::RedrawWindow() in CDirstatView::OnUpdateHINT_SHOWNEWSELECTION().
I wasn't setting the default value for column widths/order when no registry value exists, thus columns were zero-initialized. This fixes the issue by setting a default value - the functionality was there, but I'd not actually passed a default value in as a string. Duh. I'm using some heap for string formatting here, but I can fix that later.
How'd I miss this?
Reverse engineered actual queries with API Monitor.
Some performance issues (large list only) resurfaced as part of fixing the last item zombie-item bug (712e81b). This is a partial fix of the performance issues.
|
I created this PR to help keep track of history. I'm merging and closing. |
ariccio
added a commit
that referenced
this pull request
Nov 9, 2015
Add ntfs special file support, closes #9
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request ended up much larger than the branch name (
add-NTFS-special-file-support) sounds.In pursuit of 100% used-space-accounting-for (as NTFS "misreports" free space), altWinDirStat now displays the size of the NTFS Master File Table, and I've implemented experimental support for displaying the sizes of other NTFS metafiles.
I've also fixed the annoying issue (#9) where running altWinDirStat for the first time - only where the vanilla version of WinDirStat has also not been run - would display a garbled file tree & file type list.
That bug wasn't visible on my dev machine because I never actually deleted the registry key where settings are stored. Oliver Schneider & Bernhard Seifert included
Delete HKCU\Software\seifert\windirstatin the original test plan, which I don't really use. Shame on me.This pull request does suffer from one regression: working with very large folders (number of items) is a bit slower, sadly. I fixed an annoying bug where the last item in the list view would appear after the parent folder had been collapsed. I refer to it as a "zombie item".
As an example, here's the my AppData folder, expanded:
Here it is, collapsed, with "zombie item":
Here's the collapsed folder, without the "zombie item" (fixed):
Backend changes:
CDCwith the rawHDC, which improvesconst-correctness, and allows me to check return values whereMFCdoesn't.CTreeListItem*s withconst CTreeListItem*s.TRACEs.