Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Anomaly callback should be optional #24

Closed
arichiardi opened this issue Jan 19, 2019 · 1 comment
Closed

Anomaly callback should be optional #24

arichiardi opened this issue Jan 19, 2019 · 1 comment

Comments

@arichiardi
Copy link
Owner

Sometimes you don't want to use anomalies for errors, you just use normal exceptions.

It would be great if the on-anomaly param to execute is optional.
@arichiardi
Copy link
Owner Author

This is also good because if we agree with the error, result pattern that node uses, then we can use util.promisify to make it a promise easily.

arichiardi added a commit that referenced this issue Apr 8, 2019
@arichiardi
[Fix #24] Make short-circuiting for anomalies optional
2655475 
A user of the library might not need to use anomalies but just need to throw on
exceptions. This patch makes the anomaly machinery optional.

When the :anomaly? config key is truthy we now enable the functionality.

The patch is *Breaking* as it also changes the signature of fonda.core/execute
for a more node-friendly callback style - on-exception first then on-success.
arichiardi added a commit that referenced this issue Apr 8, 2019
@arichiardi
[Fix #24] Make short-circuiting for anomalies optional
e5f199e 
A user of the library might not need to use anomalies but just need to throw on
exceptions. This patch makes the anomaly machinery optional.

When the :anomaly? config key is truthy we now enable the functionality.

The patch is *Breaking* as it also changes the signature of fonda.core/execute
for a more node-friendly callback style - on-exception first then on-success.
arichiardi added a commit that referenced this issue Apr 8, 2019
@arichiardi
[Fix #24] Make short-circuiting for anomalies optional
8208232 
A user of the library might not need to use anomalies but just need to throw on
exceptions. This patch makes the anomaly machinery optional.

When the :anomaly? config key is truthy we now enable the functionality.

The patch is *Breaking* as it also changes the signature of fonda.core/execute
for a more node-friendly callback style - on-exception first then on-success.
ElChache added a commit that referenced this issue Apr 9, 2019
@ElChache
Rebased with PR #24: optional anomalies
debd1c9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@arichiardi