When root container is not Tenant, cv_container fails

[titom73]

Issue Type

• Bug Report

Module Name

cv_container

Description

Module assumes root container is always named Tenant as it is the default value. But some design have this value changed.

When root container is not Tenant then, module starts an infinite loop as it is looking for a non-existing key.

Instead of assuming root is Tenant, module should identify the root container and use it as base for the tree representation

[titom73]

Need to remove references to Tenant in default container as well:

modules/cv_container.py:    default_containers = ['Tenant', 'Undefined', 'root']

[titom73]

Dynamic root container identification tested in lab sucessfuly:

2020-01-10 10:19:16,240   -> CloudVision container {'Key': 'root', 'Name': 'Tenant', 
'CreatedBy': 'cvp system', 'CreatedOn': 1569850167062, 'Mode': 'expand', 'name': 'Tenant',
'key': 'root', 'parentName': None, 'parentId': None, 'type': None, 'id': 21,
'factoryId': 1, 'userId': None, 'childContainerId': None, 'devices': [], 'configlets': [],
'imageBundle': ''}
2020-01-10 10:19:16,240   -> CloudVision ROOT container has name Tenant

Must be tested in a setup with custom root container

[Hugh-Adams]

Thanks Thomas, I'll test it today and confirm Best Regards Hugh

…

On 10/Jan/20 09:47, Thomas Grimonet wrote: Dynamic root container identification tested in lab sucessfuly: |2020-01-10 10:19:16,240 -> CloudVision container {'Key': 'root', 'Name': 'Tenant', 'CreatedBy': 'cvp system', 'CreatedOn': 1569850167062, 'Mode': 'expand', 'name': 'Tenant', 'key': 'root', 'parentName': None, 'parentId': None, 'type': None, 'id': 21, 'factoryId': 1, 'userId': None, 'childContainerId': None, 'devices': [], 'configlets': [], 'imageBundle': ''} 2020-01-10 10:19:16,240 -> CloudVision ROOT container has name Tenant | Must be tested in a setup with custom root container — You are receiving this because you were assigned. Reply to this email directly, view it on GitHub <#113?email_source=notifications&email_token=ACWTZX5KWXS62E3MDZJ3LJLQ5A72XA5CNFSM4KEZW6P2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEITJTQQ#issuecomment-572955074>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ACWTZX7LCQCSMD5ZN4YUWITQ5A72XANCNFSM4KEZW6PQ>.

[titom73]

Tested with following scenario:

• Standard setup with Tenant as root (small playbook)
• Custom setup with User defined name for root
• Standard with AVD (large playbook)