Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix(cv_device_v3): Update format string #396

Merged
merged 4 commits into from
Sep 20, 2021
Merged

Fix(cv_device_v3): Update format string #396

merged 4 commits into from
Sep 20, 2021

Conversation

ankudinov
Copy link
Contributor

Change Summary

Fixing format string from
"{1} {2}".format(a, b)
to
"{0} {1}".format(a, b)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes)
  • Documentation content changes
  • Other (please describe):

@github-actions github-actions bot added module: cv_device_v3 Issue related to cv_device module in v3 module_utils: cv_client cv_client implementation issue labels Sep 14, 2021
@ankudinov ankudinov changed the title fix format string fix: format string Sep 14, 2021
@ankudinov ankudinov changed the title fix: format string Fix: format string Sep 14, 2021
titom73
titom73 approved these changes Sep 20, 2021
View reviewed changes
Copy link
Contributor

@titom73 titom73 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@titom73 titom73 changed the title Fix: format string Fix(cv_device_v3): format string Sep 20, 2021
@titom73 titom73 changed the title Fix(cv_device_v3): format string Fix(cv_device_v3): Update format string Sep 20, 2021
@titom73 titom73 merged commit 6ebfc91 into aristanetworks:devel Sep 20, 2021
@titom73 titom73 mentioned this pull request Sep 21, 2021
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@titom73 titom73 titom73 approved these changes

@noredistribution noredistribution Awaiting requested review from noredistribution

Assignees

@ankudinov ankudinov

Labels
module: cv_device_v3 Issue related to cv_device module in v3 module_utils: cv_client cv_client implementation issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ankudinov @titom73