Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make: Deactivate minify as workaround for Read the Doc #397

Merged
merged 2 commits into from
Sep 20, 2021
Merged

Make: Deactivate minify as workaround for Read the Doc #397

merged 2 commits into from
Sep 20, 2021

Conversation

titom73
Copy link
Contributor

@titom73 titom73 commented Sep 16, 2021

Change Summary

Current RTD build is broken as a dependency of mkdocs-minify-plugin is not compatible with latest setup_tools.
This PR deactivate minify until issue is fixed on either jsmin or mkdocs-minify-plugin

Related Issue(s)

N/A

Component(s) name

mkdocs

How to test

A temporary build on RTD should be valid

image

Result is available here

Checklist

User Checklist

  • Test build on Read the Docs

Repository Checklist

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and documentation have been updated accordingly.
  • I have updated molecule CI testing accordingly. (check the box if not applicable)

@github-actions github-actions bot added type: dependencies Issue related to repository content type: documentation Improvements or additions to documentation labels Sep 16, 2021
@github-actions
Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot added the state: conflict PR has conflict to resolve label Sep 20, 2021
@github-actions
Copy link

Conflicts have been resolved. A maintainer will review the pull request shortly.

@github-actions github-actions bot removed the state: conflict PR has conflict to resolve label Sep 20, 2021
@titom73 titom73 merged commit 6ebdcb9 into aristanetworks:devel Sep 20, 2021
@titom73 titom73 deleted the doc/mkdoc-rtd-minify-fix branch September 24, 2021 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: dependencies Issue related to repository content type: documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant