Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reformat: Python code linting #436

Merged
merged 6 commits into from
Jan 5, 2022
Merged

Reformat: Python code linting #436

merged 6 commits into from
Jan 5, 2022

Conversation

titom73
Copy link
Contributor

@titom73 titom73 commented Jan 5, 2022

Change Summary

Code Sanity:

  • Lint python code based on ansible-test
  • Update module deprecation as official ansible doc was not accurate
  • Activate ansible-test after success of any unit test defined in previous tasks

Related Issue(s)

N/A

Component(s) name

Repository

Proposed changes

  • Lint python code based on ansible-test
  • Update module deprecation as official ansible doc was not accurate
  • Activate ansible-test after success of any unit test defined in previous tasks

How to test

Run ansible-test

Checklist

User Checklist

  • Validate CI changes
  • Test deprecation message

Repository Checklist

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and documentation have been updated accordingly. (check the box if not applicable)
  • I have updated molecule CI testing accordingly. (check the box if not applicable)

@github-actions github-actions bot added module: cv_configlet Issue related to cv_configlet module module: cv_configlet_v3 Issue related to cv_cononfiglet module in v3 module: cv_container Issue related to cv_container module module: cv_container_v3 Issue related to cv_container module in v3 module: cv_device Issue related to cv_device module module: cv_device_v3 Issue related to cv_device module in v3 module: cv_facts Issue related to cv_facts module module: cv_task Issue related to cv_task module module: cv_task_v3 Issue related to cv_tasks module in v3 module_utils: cv_client cv_client implementation issue type: Code quality Issue related to code quality in repository labels Jan 5, 2022
@titom73 titom73 changed the title Reformat(module_utils): Python code linting Reformat: Python code linting Jan 5, 2022
@titom73 titom73 requested a review from mtache January 5, 2022 11:21
@titom73 titom73 mentioned this pull request Jan 5, 2022
Merged
4 tasks
@titom73 titom73 merged commit 8fbdcda into aristanetworks:devel Jan 5, 2022
@titom73 titom73 deleted the tooling/fix-ansible-test-linting branch January 5, 2022 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guillaumeVilar guillaumeVilar Awaiting requested review from guillaumeVilar

@noredistribution noredistribution Awaiting requested review from noredistribution

@mtache mtache Awaiting requested review from mtache

Assignees

@titom73 titom73

Labels
module: cv_configlet_v3 Issue related to cv_cononfiglet module in v3 module: cv_configlet Issue related to cv_configlet module module: cv_container_v3 Issue related to cv_container module in v3 module: cv_container Issue related to cv_container module module: cv_device_v3 Issue related to cv_device module in v3 module: cv_device Issue related to cv_device module module: cv_facts Issue related to cv_facts module module: cv_task_v3 Issue related to cv_tasks module in v3 module: cv_task Issue related to cv_task module module_utils: cv_client cv_client implementation issue type: Code quality Issue related to code quality in repository
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@titom73