Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for AES-256-GCM when configuring tacacs keys #1456

Closed
1 task done
c-po opened this issue Jan 25, 2022 · 3 comments · Fixed by #1466
Closed
1 task done

Add support for AES-256-GCM when configuring tacacs keys #1456

c-po opened this issue Jan 25, 2022 · 3 comments · Fixed by #1466
Labels
good first issue Good for newcomers type: enhancement New feature or request

Comments

@c-po
Copy link
Contributor

c-po commented Jan 25, 2022 •
edited
Loading

Enhancement summary

Currently TACACS keys are stored as password 7 which can be converted back from this pseudo hash to plain text.

Support should be added for AES-256-GCM

veos(config)#tacacs-server host 1.2.3.4 vrf MGMT key ?
  0     Indicates that the key string is not encrypted
  7     Specifies that a HIDDEN key will follow
  8a    Specifies that a AES-256-GCM encrypted key will follow
  LINE  Unobfuscated key string

https://github.com/aristanetworks/ansible-avd/blob/devel/ansible_collections/arista/avd/roles/eos_cli_config_gen/templates/eos/tacacs-servers.j2#L19-L21

Which component of AVD is impacted

eos_cli_config_gen

Use case example

Harden config security

Describe the solution you would like

tacacs_servers:
  hosts:
    - host: 1.2.3.4
      vrf: MGMT
      key: '132112111915143E2E200A363030'
      key_type: < 0 | 7 | 8a | default -> 7 >

Speciy key type and key in one line.

Describe alternatives you have considered

No response

Additional context

No response

Contributing Guide

  • I agree to follow this project's Code of Conduct
@c-po c-po added the type: enhancement New feature or request label Jan 25, 2022
@ClausHolbechArista
Copy link
Contributor

To avoid breaking existing deployments, maybe we could add a raw_key option, to render without the 7 in front.

@c-po
Copy link
Contributor Author

c-po commented Jan 27, 2022

What about key_type that defaults to 7?

@ClausHolbechArista
Copy link
Contributor

What about key_type that defaults to 7?

Much better proposal. Please update the issue text. Thanks

@ClausHolbechArista ClausHolbechArista added the good first issue Good for newcomers label Jan 28, 2022
c-po added a commit to c-po/ansible-avd that referenced this issue Jan 31, 2022
@c-po
Feat(eos_cli_config_gen): add support for TACACS AES-256-GCM keys (ar…
463c3aa 
…istanetworks#1456)
@c-po c-po mentioned this issue Jan 31, 2022
Merged
4 tasks
c-po added a commit to c-po/ansible-avd that referenced this issue Jan 31, 2022
@c-po
Upload artefact for issue aristanetworks#1456
9695394
ClausHolbechArista pushed a commit that referenced this issue Jan 31, 2022
@c-po
Feat(eos_cli_config_gen): Add support for TACACS AES-256-GCM keys (#1456
9a1be3c 
) (#1466)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers type: enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Feat(eos_cli_config_gen): add support for TACACS AES-256-GCM keys (#1456) c-po/ansible-avd
2 participants
@c-po @ClausHolbechArista