Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix l2vlan igmp snooping enabled not being configurable #1004

Merged

Conversation

melkypie
Copy link
Contributor

@melkypie melkypie commented Jun 7, 2021

Change Summary

Seems like with the introduction of #897, the tenant igmp snooping enabled option was changed correctly but this was overlooked.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes)
  • Documentation content changes
  • Other (please describe):

Related Issue(s)

Component(s) name

arista.avd.eos_designs

Proposed changes

How to test

Checklist:

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have updated molecule CI testing accordingly
  • All new and existing tests passed (pre-commit, make linting and make sanity-lint).

@github-actions github-actions bot added the role: eos_designs issue related to eos_designs role label Jun 7, 2021
@ClausHolbechArista ClausHolbechArista added the type: bug Something isn't working label Jun 7, 2021
@ClausHolbechArista
Copy link
Contributor

@melkypie Thanks for catching this. Can I ask you to add test coverage in molecule since it must be missing (your change did not give any molecule output changes). We should have one l2vlan with false and another with true and the rest unset.

@github-actions github-actions bot added the state: CI Updated CI scenario have been updated in the PR label Jun 7, 2021
@github-actions github-actions bot requested a review from titom73 June 7, 2021 09:11
Copy link
Contributor

@ClausHolbechArista ClausHolbechArista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ClausHolbechArista ClausHolbechArista merged commit b0de0fe into aristanetworks:devel Jun 8, 2021
@ClausHolbechArista ClausHolbechArista added this to the v2.2.0 milestone Jun 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
role: eos_designs issue related to eos_designs role state: CI Updated CI scenario have been updated in the PR type: bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants