Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CI workflow - molecule scenarios #1009

Conversation

ClausHolbechArista
Copy link
Contributor

Change Summary

Update CI workflow - molecule scenarios

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes)
  • Documentation content changes
  • Other (please describe): Update CI Workflow

Related Issue(s)

Component(s) name

arista.avd

Proposed changes

Update Molecule scenario list

  • Add eos_designs_unit_test to MOLECULE_SCENARIOS.txt to be included in make refresh-facts
  • Remove eos_l3ls_evpn-twodc-5stage-clos from MOLECULE_SCENARIOS.txt (Scenario has a new name)
  • Add evpn_underlay_rfc5549_overlay_ebgp to eos_designs CI workflow to ensure test coverage

Update CI triggers

  • Avoid eos_cli_config_gen tests to be triggered by any other molecule update
  • Simplify list of triggers for eos_cli_config_gen

How to test

Checklist:

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have updated molecule CI testing accordingly
  • All new and existing tests passed (pre-commit, make linting and make sanity-lint).

@github-actions github-actions bot added state: CI Updated CI scenario have been updated in the PR type: code quality CI and development toolset labels Jun 8, 2021
@ClausHolbechArista
Copy link
Contributor Author

@titom73 please review this one

Copy link
Member

@carlbuchmann carlbuchmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@titom73 titom73 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@titom73 titom73 added this to the v2.2.0 milestone Jun 11, 2021
@ClausHolbechArista ClausHolbechArista merged commit 2303edb into aristanetworks:devel Jun 11, 2021
@ClausHolbechArista ClausHolbechArista deleted the minor-ci-workflow-changes branch July 9, 2021 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
state: CI Updated CI scenario have been updated in the PR type: code quality CI and development toolset
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants