Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add option to not generate default configuration in eos_cli_config_gen #1015

Merged
merged 7 commits into from
Jun 11, 2021
Merged

Add option to not generate default configuration in eos_cli_config_gen #1015

merged 7 commits into from
Jun 11, 2021

Conversation

ClausHolbechArista
Copy link
Contributor

@ClausHolbechArista ClausHolbechArista commented Jun 9, 2021 •
edited
Loading

Change Summary

Add option to not generate default configuration in eos_cli_config_gen

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes)
  • Documentation content changes
  • Other (please describe):

Related Issue(s)

Part of fix for #814

Component(s) name

arista.avd.eos_cli_config_gen

Proposed changes

New knob for eos_cli_config_gen:

generate_default_config: < true | false | default -> true >

How to test

Added molecule scenario. No other configs are affected.

Checklist:

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have updated molecule CI testing accordingly
  • All new and existing tests passed (pre-commit, make linting and make sanity-lint).

@github-actions github-actions bot requested a review from onurgashi June 9, 2021 10:56
@github-actions github-actions bot added role: eos_cli_config_gen issue related to eos_cli_config_gen role state: CI Updated CI scenario have been updated in the PR labels Jun 9, 2021
onurgashi
onurgashi reviewed Jun 9, 2021
View reviewed changes
ansible_collections/arista/avd/roles/eos_cli_config_gen/templates/eos/end.j2 Outdated
@@ -0,0 +1,5 @@
{# hostname #}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be end?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

haha no. Thank you for spotting this. Too much copy/paste.

@github-actions github-actions bot requested a review from onurgashi June 9, 2021 11:22
@ClausHolbechArista ClausHolbechArista linked an issue Jun 9, 2021 that may be closed by this pull request
Provide capability to leverage eos_cli_config_gen to generate simple configlets #814
Closed
3 tasks
@ClausHolbechArista
Copy link
Contributor Author

@carlbuchmann please take a look at this one.

@ClausHolbechArista ClausHolbechArista added this to the v2.2.0 milestone Jun 11, 2021
@ClausHolbechArista ClausHolbechArista force-pushed the eos_cli_config_gen-no-default-config branch from 2c85264 to b4276ca Compare June 11, 2021 13:35
@carlbuchmann carlbuchmann force-pushed the eos_cli_config_gen-no-default-config branch from b4276ca to 55d5a2b Compare June 11, 2021 13:38
@github-actions
Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot added the state: conflict PR with conflict label Jun 11, 2021
@carlbuchmann carlbuchmann force-pushed the eos_cli_config_gen-no-default-config branch from 4d05bd2 to 2b46e1e Compare June 11, 2021 14:16
@github-actions
Copy link

Conflicts have been resolved. A maintainer will review the pull request shortly.

@github-actions github-actions bot removed the state: conflict PR with conflict label Jun 11, 2021
carlbuchmann
carlbuchmann approved these changes Jun 11, 2021
View reviewed changes
Copy link
Member

@carlbuchmann carlbuchmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

ClausHolbechArista
ClausHolbechArista commented Jun 11, 2021
View reviewed changes
Copy link
Contributor Author

@ClausHolbechArista ClausHolbechArista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ClausHolbechArista ClausHolbechArista merged commit bf90a0d into aristanetworks:devel Jun 11, 2021
@titom73 titom73 mentioned this pull request Jun 11, 2021
Merged
@ClausHolbechArista ClausHolbechArista deleted the eos_cli_config_gen-no-default-config branch July 9, 2021 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carlbuchmann carlbuchmann carlbuchmann approved these changes

@titom73 titom73 Awaiting requested review from titom73

@aphillipps aphillipps Awaiting requested review from aphillipps

@onurgashi onurgashi Awaiting requested review from onurgashi

Assignees

@ClausHolbechArista ClausHolbechArista

Labels
role: eos_cli_config_gen issue related to eos_cli_config_gen role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated
Projects
None yet
Milestone
v2.2.0
Development

Successfully merging this pull request may close these issues.

Provide capability to leverage eos_cli_config_gen to generate simple configlets
3 participants
@ClausHolbechArista @carlbuchmann @onurgashi