Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

eos_config_deploy_cvp(fix): galaxy importer issues #1028

Conversation

carlbuchmann
Copy link
Member

@carlbuchmann carlbuchmann commented Jun 11, 2021

Change Summary

Fix warning issued by galaxy-importer:

WARNING: roles/eos_config_deploy_cvp/tasks/v1/main.yml:16: risky-file-permissions File permissions unset or incorrect
WARNING: roles/eos_config_deploy_cvp/tasks/v3/main.yml:1: yaml too many blank lines (1 > 0) (empty-lines)
WARNING: roles/eos_config_deploy_cvp/tasks/v3/main.yml:14: risky-file-permissions File permissions unset or incorrect

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes)
  • Documentation content changes
  • Other (please describe):

Component(s) name

arista.avd.eos_config_deploy_cvp

Proposed changes

  • Set file permission on templates to 0644.
  • Remove blank line.

How to test

run make galaxy-importer

Checklist:

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have updated molecule CI testing accordingly
  • All new and existing tests passed (pre-commit, make linting and make sanity-lint).

@github-actions github-actions bot added the role: eos_config_deploy_cvp issue related to eos_config_deploy_cvp role label Jun 11, 2021
Copy link
Contributor

@ClausHolbechArista ClausHolbechArista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ClausHolbechArista ClausHolbechArista merged commit a9605ff into aristanetworks:devel Jun 11, 2021
@carlbuchmann carlbuchmann deleted the fix-cvp-v3-galaxy-importer branch June 25, 2021 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
role: eos_config_deploy_cvp issue related to eos_config_deploy_cvp role
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants