Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat(eos_cli_config_gen): Add patch panel support #1225

Merged
merged 13 commits into from
Nov 1, 2021
Merged

Feat(eos_cli_config_gen): Add patch panel support #1225

merged 13 commits into from
Nov 1, 2021

Conversation

emilarista
Copy link
Contributor

@emilarista emilarista commented Sep 27, 2021 •
edited
Loading

Change Summary

Adding support for patch panel commands in eos_cli_config_gen to support pseudowire patching.

Component(s) name

arista.avd.eos_cli_config_gen

Proposed changes

Added the following data model for patch panel configuration:

patch_panel:
  patches:
  - name: <patch name>
    enabled < true | false >
    connectors:
    - id: < string or integer >
      type: interface
      endpoint: < interface_name | interface_name dot1q vlan 123 >
    - id: < string or integer >
      type: pseudowire 
      endpoint: < bgp vpws TENANT_A pseudowire WPWS_PW_1 | ldp LDP_PW_1 >

Repository Checklist

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and documentation have been updated accordingly.
  • I have updated molecule CI testing accordingly. (check the box if not applicable)

@github-actions github-actions bot added role: eos_cli_config_gen issue related to eos_cli_config_gen role state: CI Updated CI scenario have been updated in the PR labels Sep 27, 2021
@emilarista emilarista marked this pull request as ready for review September 27, 2021 17:35
onurgashi
onurgashi approved these changes Sep 27, 2021
View reviewed changes
Copy link
Contributor

@onurgashi onurgashi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Do you think we might need patch-panel for each patch to shutdown/no shutdown and addition of the dot1q options?

@emilarista
Copy link
Contributor Author

LGTM!

Do you think we might need patch-panel for each patch to shutdown/no shutdown and addition of the dot1q options?

Good idea, i will add it.

@emilarista
Add dot1q support + admin shutdown key
9592a42 
Also cleaned up documentation + reran molecule
ClausHolbechArista
ClausHolbechArista requested changes Sep 28, 2021
View reviewed changes
Copy link
Contributor

@ClausHolbechArista ClausHolbechArista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also remember to add to README.md for eos_cli_config_gen.

ansible_collections/arista/avd/roles/eos_cli_config_gen/templates/eos/patch-panel.j2 Show resolved Hide resolved
ansible_collections/arista/avd/roles/eos_cli_config_gen/templates/eos/patch-panel.j2 Outdated Show resolved Hide resolved
ansible_collections/arista/avd/roles/eos_cli_config_gen/templates/eos/patch-panel.j2 Outdated Show resolved Hide resolved
ansible_collections/arista/avd/roles/eos_cli_config_gen/templates/documentation/patch-panel.j2 Outdated Show resolved Hide resolved
ansible_collections/arista/avd/roles/eos_cli_config_gen/templates/documentation/patch-panel.j2 Outdated Show resolved Hide resolved
ansible_collections/arista/avd/roles/eos_cli_config_gen/templates/documentation/patch-panel.j2 Outdated Show resolved Hide resolved
ansible_collections/arista/avd/molecule/eos_cli_config_gen/inventory/host_vars/patch-panel.yml Outdated Show resolved Hide resolved
@carlbuchmann carlbuchmann added this to the v3.1.0 milestone Sep 28, 2021
@ClausHolbechArista ClausHolbechArista marked this pull request as draft September 29, 2021 06:03
@ClausHolbechArista ClausHolbechArista marked this pull request as ready for review October 30, 2021 10:11
ClausHolbechArista
ClausHolbechArista approved these changes Oct 30, 2021
View reviewed changes
Copy link
Contributor

@ClausHolbechArista ClausHolbechArista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - only one minor remark that should be adressed.

ansible_collections/arista/avd/roles/eos_cli_config_gen/README.md Outdated
- name: < name >
enabled: < true | false >
connectors:
< there must be 2 connectors to a patch, atleast 1 of which must be an interface >
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use # for remarks

@ClausHolbechArista ClausHolbechArista merged commit b316d68 into aristanetworks:devel Nov 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ClausHolbechArista ClausHolbechArista ClausHolbechArista approved these changes

@titom73 titom73 Awaiting requested review from titom73

@aphillipps aphillipps Awaiting requested review from aphillipps

@carlbuchmann carlbuchmann Awaiting requested review from carlbuchmann

@onurgashi onurgashi Awaiting requested review from onurgashi

Assignees

@emilarista emilarista

Labels
role: eos_cli_config_gen issue related to eos_cli_config_gen role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated
Projects
None yet
Milestone
v3.1.0
Development

Successfully merging this pull request may close these issues.
4 participants
@emilarista @ClausHolbechArista @onurgashi @carlbuchmann