Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat(eos_cli_config_gen): Add loopback node-SID for ISIS-SR #1255

Merged
merged 13 commits into from
Nov 22, 2021
Merged

Feat(eos_cli_config_gen): Add loopback node-SID for ISIS-SR #1255

merged 13 commits into from
Nov 22, 2021

Conversation

emilarista
Copy link
Contributor

@emilarista emilarista commented Oct 13, 2021 •
edited
Loading

Change Summary

Adds ipv4 and ipv6 node SID configuration data model to loopback interfaces.

Component(s) name

arista.avd.eos_cli_config_gen

Proposed changes

Adds the following data model under loopback interfaces:

loopback_interfaces:
  LoopbackX:
    node_segment:
      ipv4_index: <int>
      ipv6_index: <int>

How to test

Tested in lab and molecule

Repository Checklist

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and documentation have been updated accordingly.
  • I have updated molecule CI testing accordingly. (check the box if not applicable)

@github-actions github-actions bot added role: eos_cli_config_gen issue related to eos_cli_config_gen role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated labels Oct 13, 2021
@emilarista emilarista marked this pull request as ready for review October 14, 2021 06:59
@ClausHolbechArista ClausHolbechArista added this to the v3.1.0 milestone Oct 14, 2021
@github-actions github-actions bot added the state: conflict PR with conflict label Nov 1, 2021
@github-actions
Copy link

github-actions bot commented Nov 1, 2021

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions
Copy link

github-actions bot commented Nov 8, 2021

Conflicts have been resolved. A maintainer will review the pull request shortly.

@github-actions github-actions bot removed the state: conflict PR with conflict label Nov 8, 2021
@ClausHolbechArista ClausHolbechArista modified the milestones: v3.1.0, v3.2.0 Nov 11, 2021
tgodaA
tgodaA reviewed Nov 15, 2021
View reviewed changes
ansible_collections/arista/avd/roles/eos_cli_config_gen/templates/documentation/router-isis.j2 Outdated
{% endif %}
{% endfor %}
{% endif %}
| {{ ethernet_interface }} | {{ row_isis_instance }} | {{ row_isis_metric }} | {{ row_intf_mode }} |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SIngle space required but found two {{ ethernet_interface }}

tgodaA
tgodaA reviewed Nov 15, 2021
View reviewed changes
ansible_collections/arista/avd/roles/eos_cli_config_gen/templates/documentation/router-isis.j2 Outdated
{% for ethernet_interface in ethernet_interfaces | arista.avd.natural_sort %}
{% if ethernet_interfaces[ethernet_interface].isis_enable is defined and ethernet_interfaces[ethernet_interface].isis_enable is not none %}
| {{ ethernet_interface }} | {{ ethernet_interfaces[ethernet_interface].isis_enable }} | {{ ethernet_interfaces[ethernet_interface].isis_metric | default('-') }} | {% if ethernet_interfaces[ethernet_interface].isis_network_point_to_point is defined and ethernet_interfaces[ethernet_interface].isis_network_point_to_point is not none %} point-to-point {% elif ethernet_interfaces[ethernet_interface].isis_passive is defined and ethernet_interfaces[ethernet_interface].isis_passive is not none %} passive {% else %} - {% endif %}|
{% for ethernet_interface in ethernet_interfaces | arista.avd.natural_sort %}
Copy link
Contributor

@tgodaA tgodaA Nov 15, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check jinja lint error extra space in every line until last line of code.

tgodaA
tgodaA approved these changes Nov 15, 2021
View reviewed changes
Copy link
Contributor

@tgodaA tgodaA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

ClausHolbechArista
ClausHolbechArista approved these changes Nov 22, 2021
View reviewed changes
Copy link
Contributor

@ClausHolbechArista ClausHolbechArista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ClausHolbechArista ClausHolbechArista merged commit 7652673 into aristanetworks:devel Nov 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tgodaA tgodaA tgodaA approved these changes

@ClausHolbechArista ClausHolbechArista ClausHolbechArista approved these changes

@onurgashi onurgashi Awaiting requested review from onurgashi

@titom73 titom73 Awaiting requested review from titom73

@aphillipps aphillipps Awaiting requested review from aphillipps

@carlbuchmann carlbuchmann Awaiting requested review from carlbuchmann

Assignees

@emilarista emilarista

Labels
role: eos_cli_config_gen issue related to eos_cli_config_gen role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated
Projects
None yet
Milestone
v3.2.0
Development

Successfully merging this pull request may close these issues.
3 participants
@emilarista @ClausHolbechArista @tgodaA