Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat(eos_cli_config_gen): Add vpn-ipv6 AF + vpn-ipv4 change #1259

Merged
merged 10 commits into from
Nov 11, 2021
Merged

Feat(eos_cli_config_gen): Add vpn-ipv6 AF + vpn-ipv4 change #1259

merged 10 commits into from
Nov 11, 2021

Conversation

emilarista
Copy link
Contributor

@emilarista emilarista commented Oct 14, 2021 •
edited
Loading

Change Summary

Adds vpn-ipv6 address family.

Component(s) name

arista.avd.eos_cli_config_gen

Proposed changes

Adds data model for vpn-ipv6:

router_bgp:
  address_family_vpn_ipv6:
    domain_identifier: < string >
    peer_groups:
      < peer_group_name >:
        activate: < true | false >
    neighbor_default_encapsulation_mpls_next_hop_self:
      source_interface: < interface >

How to test

Tested in lab + with molecule

Repository Checklist

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and documentation have been updated accordingly.
  • I have updated molecule CI testing accordingly. (check the box if not applicable)

@github-actions github-actions bot added role: eos_cli_config_gen issue related to eos_cli_config_gen role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated labels Oct 14, 2021
@ClausHolbechArista ClausHolbechArista added this to the v3.1.0 milestone Oct 14, 2021
@ClausHolbechArista
Copy link
Contributor

please make this change non-breaking by still accepting the old neighbor_default_encapsulation_mpls_next_hop_self. Otherwise we will have to push this out to AVD v.4

@emilarista
Copy link
Contributor Author

please make this change non-breaking by still accepting the old neighbor_default_encapsulation_mpls_next_hop_self. Otherwise we will have to push this out to AVD v.4

Made changes to accept the old data model.

@ClausHolbechArista ClausHolbechArista marked this pull request as ready for review November 1, 2021 13:42
ClausHolbechArista
ClausHolbechArista approved these changes Nov 1, 2021
View reviewed changes
Copy link
Contributor

@ClausHolbechArista ClausHolbechArista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link

github-actions bot commented Nov 2, 2021

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot added state: conflict PR with conflict filter: list_compress issue related to list_compress filter plugin filter: natural_sort issue related to natural_sort filter plugin module: configlet_build_config issue related to configlet_build_config module module: inventory_to_container issue related to inventory_to_container module role: build_output_folders issue related to build_output_folders role role: cvp_configlet_upload issue related to cvp_configlet_upload role role: dhcp_provisioner role: eos_config_deploy_cvp issue related to eos_config_deploy_cvp role role: eos_config_deploy_eapi issue related to eos_config_deploy_eapi role role: eos_designs issue related to eos_designs role role: eos_snapshot role: eos_validate_state type: code quality CI and development toolset type: documentation Improvements or additions to documentation type: Python filters labels Nov 2, 2021
@github-actions
Copy link

github-actions bot commented Nov 5, 2021

Conflicts have been resolved. A maintainer will review the pull request shortly.

@github-actions github-actions bot removed the state: conflict PR with conflict label Nov 5, 2021
@ClausHolbechArista ClausHolbechArista removed type: documentation Improvements or additions to documentation role: build_output_folders issue related to build_output_folders role role: cvp_configlet_upload issue related to cvp_configlet_upload role module: inventory_to_container issue related to inventory_to_container module role: eos_config_deploy_cvp issue related to eos_config_deploy_cvp role module: configlet_build_config issue related to configlet_build_config module role: eos_config_deploy_eapi issue related to eos_config_deploy_eapi role filter: list_compress issue related to list_compress filter plugin filter: natural_sort issue related to natural_sort filter plugin type: code quality CI and development toolset role: eos_validate_state role: dhcp_provisioner state: Documentation role Updated type: Python filters role: eos_designs issue related to eos_designs role state: CI Updated CI scenario have been updated in the PR role: eos_snapshot labels Nov 8, 2021
@github-actions github-actions bot added state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated labels Nov 10, 2021
ClausHolbechArista
ClausHolbechArista approved these changes Nov 11, 2021
View reviewed changes
Copy link
Contributor

@ClausHolbechArista ClausHolbechArista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ClausHolbechArista ClausHolbechArista merged commit c9c6d28 into aristanetworks:devel Nov 11, 2021
ccsnw pushed a commit to ccsnw/ansible-avd that referenced this pull request Nov 12, 2021
@emilarista @ccsnw
Feat(eos_cli_config_gen): Add vpn-ipv6 AF + vpn-ipv4 change (aristane…
b6a5bd8 
…tworks#1259)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ClausHolbechArista ClausHolbechArista ClausHolbechArista approved these changes

@titom73 titom73 Awaiting requested review from titom73

@aphillipps aphillipps Awaiting requested review from aphillipps

@carlbuchmann carlbuchmann Awaiting requested review from carlbuchmann

@onurgashi onurgashi Awaiting requested review from onurgashi

Assignees

@emilarista emilarista

Labels
role: eos_cli_config_gen issue related to eos_cli_config_gen role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated
Projects
None yet
Milestone
v3.1.0
Development

Successfully merging this pull request may close these issues.
3 participants
@emilarista @ClausHolbechArista @onurgashi