Feat(eos_cli_config_gen): Enable or disable specific snmp-server traps

[tgodaA]

Change Summary

This feature supports to enable specific snmp-server traps

Related Issue(s)

Fixes #1152

Component(s) name

arista.avd.eos_cli_config_gen

Proposed changes

Old data model:

snmp_server:
  traps:
    enable: < true | false >

New model:

snmp_server:
  traps:
    # Enable/Disable all snmp-traps
    enable: < true | false >
    # Enable/Disable specific snmp-trap types an their sub_trap types
    snmp_traps:
      - name: < snmp_trap_type | snmp_trap_type snmp_sub_trap_type >
        enabled: < true | false | default --> true >
      - name: < snmp_trap_type | snmp_trap_type snmp_sub_trap_type >

How to test

New molecule test snmp-server-traps was added.

Repository Checklist

• [ x] My code has been rebased from devel before I start
• [ x] I have read the CONTRIBUTING document.
• [ x] My change requires a change to the documentation and documentation have been updated accordingly.
• [ x] I have updated molecule CI testing accordingly. (check the box if not applicable)

[c-po]

This also fixes #1231

Can I also enable all but disable specific traps?

[tgodaA]

@c-po, as per your description in #1231, there are some breaking changes. So I made up this model. Please check this molecule example: https://github.com/aristanetworks/ansible-avd/pull/1294/files#diff-503d0c73eb3ff86d35c8d52d8d880568c8ba3779505cda381363abbc83dfa8c6

When we say enable all it will enable everything by default and can't disable specific traps. So the keyword
enable: false should be set or don't define enable: <>. Then define the traps and sub_trap types and the output will be: https://github.com/aristanetworks/ansible-avd/pull/1294/files#diff-c36210703f4675127262674befd7070682a3771d74cbcf5a8e60808305b04202

The molecule example will give you a better idea.

[tgodaA]

This new model should enable/disable any traps or all traps.

[xaviramon]

Check changes to protect wrong use and we can discuss about SNMP trap as a whole.

[xaviramon]

LGTM!

[ClausHolbechArista]

LGTM