Fix(eos_config_deploy_cvp): avoid making CV_DEVICES becoming None

[noredistribution]

… devices

Change Summary

Related Issue(s)

Fixes #

Component(s) name

arista.avd.eos_config_deploy_cvp

Proposed changes

in https://github.com/aristanetworks/ansible-avd/blob/devel/ansible_collections/arista/avd/roles/eos_config_deploy_cvp/templates/cvp-devices-v3.j2
if the device_filter does not match any devices inside the for loop CVP_DEVICES will be empty, so it'll become None and then on the ansible-cvp side we'll get that TypeError traceback mentioned in the #1293

This will only set CVP_DEVICES to an empty list, and then validation should be done in the cv_devices_v3 module on ansible-cvp side

How to test

To check if the list will become empty simply print the CVP_DEVICES var in https://github.com/aristanetworks/ansible-avd/blob/devel/ansible_collections/arista/avd/roles/eos_config_deploy_cvp/tasks/v3/present.yml after L41
like this:

- name: "Print CVP_DEVICES_RESULTS"
  ansible.builtin.debug:
    var: CVP_DEVICES

which should result in

TASK [arista.avd.eos_config_deploy_cvp : Configure devices on AVD-CVP-1] **********************************************************
ok: [AVD-CVP-1]

TASK [arista.avd.eos_config_deploy_cvp : Print CVP_DEVICES_RESULTS] ***************************************************************
ok: [AVD-CVP-1] => {
    "CVP_DEVICES": []
}

Checklist

User Checklist

• N/A

Repository Checklist

• My code has been rebased from devel before I start
• I have read the CONTRIBUTING document.
• My change requires a change to the documentation and documentation have been updated accordingly.
• I have updated molecule CI testing accordingly. (check the box if not applicable)

[ClausHolbechArista]

LGTM

Dismissing, since we will rework this to add error messages in case of no devices matched by the filter.

[tgodaA]

LGTM

[ClausHolbechArista]

LGTM - we don't need an error message, since it is not necessarily an error that no devices where ready to be deployed. So we will just parse the empty list along to the cvp modules and they will return without any action being done.