Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat(eos_cli_config_gen): Add support for IPv6 address virtual in vlan_interfaces #1312

Merged
merged 5 commits into from
Dec 7, 2021

Conversation

ifoughal
Copy link
Contributor

@ifoughal ifoughal commented Nov 5, 2021

Change Summary

Adds SVI support for IPv6 following the latest CLI feature:
IPv6 address virtual A:B:C:D:E:F:G:H/I

Related Issue(s)

Fixes #1106

Component(s) name

arista.avd.eos_cli_config_gen

Proposed changes

EOS config example of dual-stack SVI and "ipv6 address virtual":

interface Vlan10
   vrf red
   ipv6 enable
   ipv6 address virtual fc00:10::254/64  
   ip address virtual 10.10.10.254/24

Can be defined as:

vlan_interfaces:
    Vlan10:
      ip_address_virtual: 10.10.10.254/24
      ipv6_address_virtual: fc00:10::254/64

How to test

Generate configuration with the the data model feature on a Vlan interface.

Checklist

User Checklist

  • N/A

Repository Checklist

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and documentation have been updated accordingly.
  • I have updated molecule CI testing accordingly. (check the box if not applicable)

@github-actions github-actions bot added role: eos_cli_config_gen issue related to eos_cli_config_gen role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated labels Nov 5, 2021
@ifoughal ifoughal changed the title Ipv6 address virtual Feat:Ipv6 address virtual Nov 5, 2021
@ifoughal ifoughal changed the title Feat:Ipv6 address virtual Feat(eos_cli_config_gen): Added SVI support for "ipv6 address virtual": Nov 5, 2021
@@ -125,20 +127,27 @@ interface Management1

#### IPv6

| Interface | VRF | IPv6 Address | Virtual Router Address | VRRP | ND RA Disabled | Managed Config Flag | IPv6 ACL In | IPv6 ACL Out |
| Interface | VRF | IPv6 Address | IPv6 Address Virtual | Virtual Router Address | VRRP | ND RA Disabled | Managed Config Flag | IPv6 ACL In | IPv6 ACL Out |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you add these entries manually? I don't see any change in jinja template for documentation that renders this configuration.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have indeed added them manually on the documentation, wasn't sure whether it was auto generated or not.

As for the jinja template that renders that configuration:
eos_cli_config_gen/templates/eos/vlan-interfaces.j2 [LINE 66]

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So, in the check details, it seems that there's a conflict indeed in the documentation regarding vlans, due the the field that I have added.

Should I revert the documentation back?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is auto-generated. There should be a jinja template in the documentation folder.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also you need to run molecule to test. Check this page https://avd.sh/en/releases-v3.x.x/molecule/index.html#ansible-molecule

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let me know if you can do it. Else I will take this PR as I was already working on this.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please solve it? I'm really not that familiar with molecule, same with the documentation, I'm not sure what to define there exactly.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, I will take this PR.

@xaviramon
Copy link
Contributor

Documentation is missing. I believe this PR should be moved into DRAFT until we add the documentation and fix the molecule scenario.
I have some time, so I can also develop this feature.

@tgodaA tgodaA assigned tgodaA and unassigned ifoughal Nov 8, 2021
@tgodaA
Copy link
Contributor

tgodaA commented Nov 8, 2021

I am working on this already. There is an issue related to this PR.

@tgodaA tgodaA changed the title Feat(eos_cli_config_gen): Added SVI support for "ipv6 address virtual": Feat(eos_cli_config_gen): Added SVI support for IPv6 virtual address Nov 8, 2021
@tgodaA tgodaA marked this pull request as draft November 8, 2021 19:56
@tgodaA tgodaA changed the title Feat(eos_cli_config_gen): Added SVI support for IPv6 virtual address Feat(eos_cli_config_gen): Add SVI support for IPv6 virtual address Nov 8, 2021
@tgodaA tgodaA self-requested a review November 8, 2021 20:59
@tgodaA tgodaA marked this pull request as ready for review November 8, 2021 21:07
@tgodaA tgodaA removed their request for review November 8, 2021 21:07
Copy link
Contributor

@xaviramon xaviramon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

As we are sorting the list later, while it is added to the document.
Copy link
Member

@carlbuchmann carlbuchmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@carlbuchmann carlbuchmann changed the title Feat(eos_cli_config_gen): Add SVI support for IPv6 virtual address Feat(eos_cli_config_gen): Add support for IPv6 address virtual in vlan_interfaces Dec 7, 2021
@carlbuchmann carlbuchmann merged commit 96b9ad3 into aristanetworks:devel Dec 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
role: eos_cli_config_gen issue related to eos_cli_config_gen role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for IPv6 overlay
5 participants