-
Notifications
You must be signed in to change notification settings - Fork 219
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat(eos_cli_config_gen): Add support for IPv6 address virtual in vlan_interfaces #1312
Feat(eos_cli_config_gen): Add support for IPv6 address virtual in vlan_interfaces #1312
Conversation
ansible_collections/arista/avd/roles/eos_cli_config_gen/README.md
Outdated
Show resolved
Hide resolved
@@ -125,20 +127,27 @@ interface Management1 | |||
|
|||
#### IPv6 | |||
|
|||
| Interface | VRF | IPv6 Address | Virtual Router Address | VRRP | ND RA Disabled | Managed Config Flag | IPv6 ACL In | IPv6 ACL Out | | |||
| Interface | VRF | IPv6 Address | IPv6 Address Virtual | Virtual Router Address | VRRP | ND RA Disabled | Managed Config Flag | IPv6 ACL In | IPv6 ACL Out | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you add these entries manually? I don't see any change in jinja template for documentation that renders this configuration.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have indeed added them manually on the documentation, wasn't sure whether it was auto generated or not.
As for the jinja template that renders that configuration:
eos_cli_config_gen/templates/eos/vlan-interfaces.j2 [LINE 66]
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So, in the check details, it seems that there's a conflict indeed in the documentation regarding vlans, due the the field that I have added.
Should I revert the documentation back?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is auto-generated. There should be a jinja template in the documentation folder.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Check this jinja template. Make changes to this template: https://github.com/aristanetworks/ansible-avd/blob/bf99bca2dbed1c70f09bfd11b23d1296c3e5e7b2/ansible_collections/arista/avd/roles/eos_cli_config_gen/templates/documentation/vlan-interfaces.j2
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also you need to run molecule to test. Check this page https://avd.sh/en/releases-v3.x.x/molecule/index.html#ansible-molecule
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let me know if you can do it. Else I will take this PR as I was already working on this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please solve it? I'm really not that familiar with molecule, same with the documentation, I'm not sure what to define there exactly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, I will take this PR.
Documentation is missing. I believe this PR should be moved into DRAFT until we add the documentation and fix the molecule scenario. |
I am working on this already. There is an issue related to this PR. |
bf99bca
to
64f1955
Compare
4f568b9
to
ad5f032
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
As we are sorting the list later, while it is added to the document.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Change Summary
Adds SVI support for IPv6 following the latest CLI feature:
IPv6 address virtual A:B:C:D:E:F:G:H/I
Related Issue(s)
Fixes #1106
Component(s) name
arista.avd.eos_cli_config_gen
Proposed changes
EOS config example of dual-stack SVI and "ipv6 address virtual":
Can be defined as:
How to test
Generate configuration with the the data model feature on a Vlan interface.
Checklist
User Checklist
Repository Checklist