-
Notifications
You must be signed in to change notification settings - Fork 219
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat(eos_cli_config_gen): Support connectivity monitor configuration #1322
Conversation
...lections/arista/avd/roles/eos_cli_config_gen/templates/documentation/monitor-connectivity.j2
Show resolved
Hide resolved
...lections/arista/avd/roles/eos_cli_config_gen/templates/documentation/monitor-connectivity.j2
Outdated
Show resolved
Hide resolved
ansible_collections/arista/avd/roles/eos_cli_config_gen/README.md
Outdated
Show resolved
Hide resolved
ansible_collections/arista/avd/roles/eos_cli_config_gen/templates/eos/monitor-connectivity.j2
Outdated
Show resolved
Hide resolved
ansible_collections/arista/avd/roles/eos_cli_config_gen/templates/eos/monitor-connectivity.j2
Outdated
Show resolved
Hide resolved
ansible_collections/arista/avd/roles/eos_cli_config_gen/README.md
Outdated
Show resolved
Hide resolved
...lections/arista/avd/molecule/eos_cli_config_gen/inventory/host_vars/monitor-connectivity.yml
Outdated
Show resolved
Hide resolved
ansible_collections/arista/avd/roles/eos_cli_config_gen/README.md
Outdated
Show resolved
Hide resolved
...lections/arista/avd/roles/eos_cli_config_gen/templates/documentation/monitor-connectivity.j2
Show resolved
Hide resolved
ansible_collections/arista/avd/roles/eos_cli_config_gen/templates/eos/monitor-connectivity.j2
Show resolved
Hide resolved
ansible_collections/arista/avd/roles/eos_cli_config_gen/templates/eos/monitor-connectivity.j2
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
minor indentation fixes to do, but other than that looks good to me.
...lections/arista/avd/molecule/eos_cli_config_gen/inventory/host_vars/monitor-connectivity.yml
Outdated
Show resolved
Hide resolved
ansible_collections/arista/avd/roles/eos_cli_config_gen/README.md
Outdated
Show resolved
Hide resolved
ansible_collections/arista/avd/roles/eos_cli_config_gen/README.md
Outdated
Show resolved
Hide resolved
moving back the description for Custom Daemons.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Change Summary
Support for Monitor connectivity cli commands, both global and vrf configuration.
Related Issue(s)
Fixes #1094
Component(s) name
arista.avd.eos_cli_config_gen
Proposed changes
Proposed model:
How to test
Molecule scenario monitor-connectivity is added for reference.
Checklist
User Checklist
Repository Checklist