Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doc: Adding quotes to keys accepting the string value "on" #1324

Conversation

ClausHolbechArista
Copy link
Contributor

Change Summary

Adding quotes to keys accepting the string value "on"

Related Issue(s)

Fixes #1321

Component(s) name

arista.avd.eos_cli_config_gen
arista.avd.eos_designs

Proposed changes

Added quotes to the documentation for keys that accept the string "on". If the user enters on without quotes, Ansible will convert it to the boolean True.

How to test

N/A Only doc change.

Checklist

User Checklist

  • N/A

Repository Checklist

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and documentation have been updated accordingly.
  • I have updated molecule CI testing accordingly. (check the box if not applicable)

Copy link
Member

@carlbuchmann carlbuchmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@carlbuchmann carlbuchmann merged commit a14ce3c into aristanetworks:devel Nov 13, 2021
ccsnw pushed a commit to ccsnw/ansible-avd that referenced this pull request Nov 16, 2021
@ClausHolbechArista ClausHolbechArista deleted the docfix-port-channel-mode-on-with-quotes branch December 22, 2022 07:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
role: eos_cli_config_gen issue related to eos_cli_config_gen role role: eos_designs issue related to eos_designs role state: Documentation role Updated
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect parsing of AVD configuration to Configs
2 participants