-
Notifications
You must be signed in to change notification settings - Fork 220
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Doc(eos_cli_config_gen): Add Documentation for Management Console #1332
Doc(eos_cli_config_gen): Add Documentation for Management Console #1332
Conversation
...ollections/arista/avd/roles/eos_cli_config_gen/templates/documentation/management-console.j2
Outdated
Show resolved
Hide resolved
...ollections/arista/avd/roles/eos_cli_config_gen/templates/documentation/management-console.j2
Outdated
Show resolved
Hide resolved
This PR is adding document, so this should be Doc(eos_cli_config_gen). FYI:
Also we don't add linked issue # in the PR title. We just link the related issues. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Change Summary
Adding documentation for Management Console
Related Issue(s)
Fixes #1271
Component(s) name
arista.avd.eos_cli_config_gen
Proposed changes
If management_console.idle_timeout is defined, render it in the documentation as:
"Management Console Timeout is set to < management_console.idle_timeout > minutes."
If required, I can add a case for tranlasting "0" to "disabled" instead of rendering "0 minutes"
How to test
Molecule run
Checklist
User Checklist
Repository Checklist