Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Doc: Fix typos and documentation errors #1334

Merged
merged 4 commits into from
Nov 23, 2021
Merged

Doc: Fix typos and documentation errors #1334

merged 4 commits into from
Nov 23, 2021

Conversation

tgodaA
Copy link
Contributor

@tgodaA tgodaA commented Nov 16, 2021 •
edited by titom73
Loading

Change Summary

Fix documentation errors

Related Issue(s)

Component(s) name

Proposed changes

How to test

Checklist

User Checklist

  • N/A

Repository Checklist

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and documentation have been updated accordingly.
  • I have updated molecule CI testing accordingly. (check the box if not applicable)

@github-actions github-actions bot added role: cvp_configlet_upload issue related to cvp_configlet_upload role role: eos_designs issue related to eos_designs role state: Documentation role Updated type: documentation Improvements or additions to documentation labels Nov 16, 2021
@tgodaA tgodaA changed the title Docs: Fix typos and documentation errors Doc: Fix typos and documentation errors Nov 16, 2021
@tgodaA tgodaA added this to the v3.2.0 milestone Nov 16, 2021
titom73
titom73 approved these changes Nov 18, 2021
View reviewed changes
Copy link
Contributor

@titom73 titom73 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

emilarista
emilarista approved these changes Nov 23, 2021
View reviewed changes
Copy link
Contributor

@emilarista emilarista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

ClausHolbechArista
ClausHolbechArista approved these changes Nov 23, 2021
View reviewed changes
Copy link
Contributor

@ClausHolbechArista ClausHolbechArista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ClausHolbechArista ClausHolbechArista merged commit 80427bd into aristanetworks:devel Nov 23, 2021
@tgodaA tgodaA deleted the docs branch November 23, 2021 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@titom73 titom73 titom73 approved these changes

@ClausHolbechArista ClausHolbechArista ClausHolbechArista approved these changes

@emilarista emilarista emilarista approved these changes

@carlbuchmann carlbuchmann Awaiting requested review from carlbuchmann

Assignees

@tgodaA tgodaA

Labels
role: cvp_configlet_upload issue related to cvp_configlet_upload role role: eos_designs issue related to eos_designs role state: Documentation role Updated type: documentation Improvements or additions to documentation
Projects
None yet
Milestone
v3.2.0
Development

Successfully merging this pull request may close these issues.
4 participants
@tgodaA @titom73 @ClausHolbechArista @emilarista