Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Doc(eos_cli_config_gen): Add Documentation for Clock Timezone #1338

Merged
merged 7 commits into from
Nov 22, 2021
Merged

Doc(eos_cli_config_gen): Add Documentation for Clock Timezone #1338

merged 7 commits into from
Nov 22, 2021

Conversation

ccsnw
Copy link
Contributor

@ccsnw ccsnw commented Nov 17, 2021

Change Summary

Add Documentation for Clock Timezone

Related Issue(s)

Fixes #1270

Component(s) name

arista.avd.eos_cli_config_gen

Proposed changes

Add clock timezone config to documentation if defined

How to test

molecule test

Checklist

User Checklist

  • N/A

Repository Checklist

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and documentation have been updated accordingly.
  • I have updated molecule CI testing accordingly. (check the box if not applicable)

@github-actions github-actions bot added role: eos_cli_config_gen issue related to eos_cli_config_gen role state: CI Updated CI scenario have been updated in the PR labels Nov 17, 2021
tgodaA
tgodaA approved these changes Nov 17, 2021
View reviewed changes
Copy link
Contributor

@tgodaA tgodaA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

ClausHolbechArista
ClausHolbechArista requested changes Nov 22, 2021
View reviewed changes
Copy link
Contributor

@ClausHolbechArista ClausHolbechArista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I cannot see the old clock-timezone.j2 getting deleted, but apart from that, this looks good to me.
Thank you for this contribution!
Please delete the file and push. If tests go well, we will merge.

ansible_collections/arista/avd/roles/eos_cli_config_gen/templates/eos-intended-config.j2 Show resolved Hide resolved
titom73
titom73 approved these changes Nov 22, 2021
View reviewed changes
Copy link
Contributor

@titom73 titom73 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update.

Looks good now !

ClausHolbechArista
ClausHolbechArista approved these changes Nov 22, 2021
View reviewed changes
Copy link
Contributor

@ClausHolbechArista ClausHolbechArista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ClausHolbechArista ClausHolbechArista merged commit 65f0047 into aristanetworks:devel Nov 22, 2021
@ccsnw ccsnw deleted the clock branch November 22, 2021 18:01
@carlbuchmann carlbuchmann added this to the v3.2.0 milestone Dec 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tgodaA tgodaA tgodaA approved these changes

@ClausHolbechArista ClausHolbechArista ClausHolbechArista approved these changes

@titom73 titom73 titom73 approved these changes

@onurgashi onurgashi Awaiting requested review from onurgashi

@aphillipps aphillipps Awaiting requested review from aphillipps

@carlbuchmann carlbuchmann Awaiting requested review from carlbuchmann

Assignees

@ccsnw ccsnw

Labels
role: eos_cli_config_gen issue related to eos_cli_config_gen role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated
Projects
None yet
Milestone
v3.2.0
Development

Successfully merging this pull request may close these issues.

Clock Missing from Device Documentation
5 participants
@ccsnw @titom73 @ClausHolbechArista @tgodaA @carlbuchmann