Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat(eos_cli_config_gen): Add password minimum length to Management Security #1344

Merged
merged 1 commit into from
Nov 22, 2021
Merged

Feat(eos_cli_config_gen): Add password minimum length to Management Security #1344

merged 1 commit into from
Nov 22, 2021

Conversation

ccsnw
Copy link
Contributor

@ccsnw ccsnw commented Nov 18, 2021

Change Summary

Adds option to define minimum password length for management security

Related Issue(s)

Fixes #1343

Component(s) name

arista.avd.eos_cli_config_gen

Proposed changes

management_security:
  entropy_source: < entropy_source >
  password:
    minimum_length: <0-32>
    encryption_key_common: < true | false >

How to test

molecule run

Checklist

User Checklist

  • N/A

Repository Checklist

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and documentation have been updated accordingly.
  • I have updated molecule CI testing accordingly. (check the box if not applicable)

@github-actions github-actions bot added role: eos_cli_config_gen issue related to eos_cli_config_gen role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated labels Nov 18, 2021
xaviramon
xaviramon approved these changes Nov 22, 2021
View reviewed changes
Copy link
Contributor

@xaviramon xaviramon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

titom73
titom73 approved these changes Nov 22, 2021
View reviewed changes
Copy link
Contributor

@titom73 titom73 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@titom73 titom73 added this to the v3.2.0 milestone Nov 22, 2021
@titom73 titom73 merged commit faf40ff into aristanetworks:devel Nov 22, 2021
@ccsnw ccsnw deleted the management-security branch November 22, 2021 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xaviramon xaviramon xaviramon approved these changes

@titom73 titom73 titom73 approved these changes

@onurgashi onurgashi Awaiting requested review from onurgashi

@aphillipps aphillipps Awaiting requested review from aphillipps

@carlbuchmann carlbuchmann Awaiting requested review from carlbuchmann

Assignees

@ccsnw ccsnw

Labels
role: eos_cli_config_gen issue related to eos_cli_config_gen role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated
Projects
None yet
Milestone
v3.2.0
Development

Successfully merging this pull request may close these issues.

Setting Password Minimum Length on Management Security (eos_cli_config_gen)
3 participants
@ccsnw @titom73 @xaviramon