Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix(eos_designs): mlag xx is rendered on port-channels to servers even when switches do not run mlag. #1356

Merged
merged 3 commits into from
Nov 24, 2021

Conversation

carlbuchmann
Copy link
Member

@carlbuchmann carlbuchmann commented Nov 23, 2021

Change Summary

Add logic to test for switch.mlag to the connected_endpoint port-channel templates.

Related Issue(s)

Fixes #1318

Component(s) name

arista.avd.eos_designs

How to test

See Molecule scenarios results.

Checklist

Repository Checklist

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and documentation have been updated accordingly.
  • I have updated molecule CI testing accordingly. (check the box if not applicable)

@github-actions github-actions bot added role: eos_designs issue related to eos_designs role state: CI Updated CI scenario have been updated in the PR labels Nov 23, 2021
@carlbuchmann carlbuchmann added the type: bug Something isn't working label Nov 23, 2021
@carlbuchmann carlbuchmann added this to the v3.2.0 milestone Nov 23, 2021
Copy link
Contributor

@tgodaA tgodaA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Nice catch Carl!

@carlbuchmann carlbuchmann merged commit 5d83e81 into aristanetworks:devel Nov 24, 2021
@carlbuchmann carlbuchmann deleted the fix-issue-1318 branch April 18, 2023 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
role: eos_designs issue related to eos_designs role state: CI Updated CI scenario have been updated in the PR type: bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

eos_designs - mlag xx is rendered on port-channels to servers even when switches do not run mlag.
2 participants