Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat(eos_cli_config_gen): extend vxlan interface data model to support multicast configuration #1368

Merged
merged 6 commits into from
Nov 30, 2021
Merged

Feat(eos_cli_config_gen): extend vxlan interface data model to support multicast configuration #1368

merged 6 commits into from
Nov 30, 2021

Conversation

carlbuchmann
Copy link
Member

@carlbuchmann carlbuchmann commented Nov 28, 2021 •
edited
Loading

Change Summary

Extend vxlan interface data model for multicast support.

Related Issue(s)

Fixes #1363

Component(s) name

arista.avd.eos_cli_config_gen

Proposed changes

vxlan_interface:
  Vxlan1:
    vxlan:
      mlag_source_interface: < source_interface_name >
      vlans:
        < vlan_id_1 >:
          multicast_group: < ip_multicast_group_address >
        < vlan_id_2 >:
          vni: < vni_id_2 >
          multicast_group: < ip_multicast_group_address >
      vrfs:
        < vrf_name_1 >:
          multicast_group: < ip_multicast_group_address >
        < vrf_name_2 >:
          multicast_group: < ip_multicast_group_address >

How to test

See Molecule Scenario

Checklist

User Checklist

  • N/A

Repository Checklist

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and documentation have been updated accordingly.
  • I have updated molecule CI testing accordingly. (check the box if not applicable)

@github-actions github-actions bot added role: eos_cli_config_gen issue related to eos_cli_config_gen role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated labels Nov 28, 2021
@carlbuchmann carlbuchmann added this to the v3.2.0 milestone Nov 28, 2021
xaviramon
xaviramon approved these changes Nov 30, 2021
View reviewed changes
Copy link
Contributor

@xaviramon xaviramon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

titom73
titom73 approved these changes Nov 30, 2021
View reviewed changes
Copy link
Contributor

@titom73 titom73 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Nice use of shorten for/if blocks

@titom73 titom73 merged commit aedf272 into aristanetworks:devel Nov 30, 2021
@carlbuchmann carlbuchmann deleted the feature-vxlan-multicast branch April 18, 2023 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xaviramon xaviramon xaviramon approved these changes

@titom73 titom73 titom73 approved these changes

Assignees

@carlbuchmann carlbuchmann

Labels
role: eos_cli_config_gen issue related to eos_cli_config_gen role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated
Projects
None yet
Milestone
v3.2.0
Development

Successfully merging this pull request may close these issues.

Support VRF multicast group in VXLAN interface
3 participants
@carlbuchmann @titom73 @xaviramon