Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix(eos_designs): Honor evpn_services_l2_only setting #1394

Merged
merged 3 commits into from
Dec 13, 2021
Merged

Fix(eos_designs): Honor evpn_services_l2_only setting #1394

merged 3 commits into from
Dec 13, 2021

Conversation

ClausHolbechArista
Copy link
Contributor

@ClausHolbechArista ClausHolbechArista commented Dec 8, 2021 •
edited by carlbuchmann
Loading

Change Summary

Fix evpn_services_l2_only setting which got broken by recent refactoring.

Related Issue(s)

Fixes #

Component(s) name

arista.avd.eos_designs

Proposed changes

  • Fix implementation of evpn_services_l2_only
  • Fix issue with not using node_groups for l3leaf (found during molecule implementation for evpn_services_l2_only)
  • Add molecule coverage for evpn_services_l2_only

How to test

Added molecule coverage for both true and false to make it simple to compare.

Checklist

User Checklist

  • N/A

Repository Checklist

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and documentation have been updated accordingly.
  • I have updated molecule CI testing accordingly. (check the box if not applicable)

@github-actions github-actions bot added role: eos_designs issue related to eos_designs role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated labels Dec 8, 2021
carlbuchmann
carlbuchmann approved these changes Dec 13, 2021
View reviewed changes
Copy link
Member

@carlbuchmann carlbuchmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@carlbuchmann carlbuchmann merged commit 8974bb3 into aristanetworks:devel Dec 13, 2021
@tgodaA tgodaA mentioned this pull request Dec 15, 2021
Merged
4 tasks
@carlbuchmann carlbuchmann added this to the v3.2.0 milestone Dec 17, 2021
@ClausHolbechArista ClausHolbechArista deleted the fix-evpn_services_l2_only branch December 22, 2022 07:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tgodaA tgodaA tgodaA left review comments

@carlbuchmann carlbuchmann carlbuchmann approved these changes

Assignees

@ClausHolbechArista ClausHolbechArista

Labels
role: eos_designs issue related to eos_designs role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated
Projects
None yet
Milestone
v3.2.0
Development

Successfully merging this pull request may close these issues.
3 participants
@ClausHolbechArista @carlbuchmann @tgodaA