Feat(eos_cli_config_gen): port-channel-interfaces enhancement

[UchihaItachiSama]

Change Summary

PR to add support for:

• single-active multi-homing redundancy mode
• designated-forwarder election algorithm

Reference article

Related Issue(s)

Fixes #1163

Component(s) name

arista.avd.eos_cli_config_gen

Proposed changes

Added following changes to the port-channel-interfaces.yml

  < Port-Channel_interface_2 >:
    <snipped>
    redundancy: < Multihoming redundancy mode (all-active | single-active | default --> all-active) >
    designated_forwarder_election:
      algorithm: < modulus | preference | default --> modulus >
      preference_value: < Preference value (0-65535) >
      dont_preempt: < non-revertive DF election mode ( true | false | default --> false ) >

YAML

  Port-Channel60:
    description: server01_PortChannel3
    vlans: 1-4000
    mode: trunk
    esi: 0000:0000:0101:0102:0033
    rt: 01:01:01:02:00:33
    lacp_id: 0101.0102.0033
    redundancy: single-active
    designated_forwarder_election:
      algorithm: preference
      preference_value: 1000
      dont_preempt: true

CLI

interface Port-Channel60
   description server01_PortChannel3
   switchport
   switchport trunk allowed vlan 1-4000
   switchport mode trunk
   evpn ethernet-segment
      identifier 0000:0000:0101:0102:0033
      route-target import 01:01:01:02:00:33
      redundancy single-active
      designated-forwarder election algorithm preference 1000 dont-preempt
   lacp system-id 0101.0102.0033

How to test

Ran molecule test which resulted in generation of TOC documentation and intended configuration

molecule test --scenario-name eos_cli_config_gen

Checklist

User Checklist

• N/A

Repository Checklist

• My code has been rebased from devel before I start
• I have read the CONTRIBUTING document.
• My change requires a change to the documentation and documentation have been updated accordingly.
• I have updated molecule CI testing accordingly. (check the box if not applicable)

[tgodaA]

you need to run make refresh-facts from ansible_collections/arista/avd/molecule directory. This will run molecule test cases for all scenarios.

[tgodaA]

Also the data model doesn't match with the eos cli. Even the esi and rt should have been inside a knob evpn or evpn_es.

My suggestion for the data model would be:

evpn_es:
  redundancy: < active-active | single-active | default --> active-active >
  designated_forwarder_election:
    hold_time: < time seconds >
    algorithm: <>
    preference_value: <>
    dont_preempt: <>

I don't have a router to test the possible commands. Let's see what others will suggest.

[UchihaItachiSama]

you need to run make refresh-facts from ansible_collections/arista/avd/molecule directory. This will run molecule test cases for all scenarios.

Sure, will run the make refresh-facts. Do we need this all time for eos_cli_config_gen? If so should be update the molecule README

[UchihaItachiSama]

Also the data model doesn't match with the eos cli. Even the esi and rt should have been inside a knob evpn or evpn_es.

Yeah, since we are adding the designated_forwarder_election and redundancy it would be better to include esi and rt also under evpn ethernet-segment similar to the CLI.

For the key should we keep it evpn_ethernet_segment or evpn_es?

port_channel_interfaces:
  < Port-Channel_interface_1 >:
  evpn_es / evpn_ethernet_segment:
      esi: < EVPN Ethernet Segment Identifier (Type 1 format) >
      rt: < EVPN Route Target for ESI with format xx:xx:xx:xx:xx:xx >
      redundancy: < active-active | single-active | default --> active-active >
      designated_forwarder_election:
           hold_time: < time seconds >
           algorithm: <>
           preference_value: <>
           dont_preempt: <>

[tgodaA]

Hi Himanshu, we can add esi and rt under evpn_ethernet_segment but I guess it is a breaking change. So let's leave them for now unless if everyone agrees to move them.

[UchihaItachiSama]

Hi Himanshu, we can add esi and rt under evpn_ethernet_segment but it is a breaking change. So let's leave them for now unless if everyone agrees to move them.

Hey Tony, sure. For now i'll update the data model as follows

  < Port-Channel_interface_2 >:
    description: < description >
    vlans: "< list of vlans as string >"
    mode: < access | dot1q-tunnel | trunk | "trunk phone" >
    esi: < EVPN Ethernet Segment Identifier (Type 1 format) >
    rt: < EVPN Route Target for ESI with format xx:xx:xx:xx:xx:xx >
    lacp_id: < LACP ID with format xxxx.xxxx.xxxx >
    evpn_ethernet_segment:
       redundancy: < Multihoming redundancy mode (all-active | single-active | default --> all-active) >
       designated_forwarder_election:
         algorithm: < modulus | preference | default --> modulus >
         preference_value: < Preference value (0-65535) >
         hold_time: < time seconds >
         dont_preempt: < non-revertive DF election mode ( true | false | default --> false ) >

[lermilov]

Hi Himanshu!
From EVPN-VXLAN perspective looks good to me. However, for EVPN-MPLS MH I would recommend to add followig knob to cli_config_gen:
interface Ethernet4
switchport access vlan 1000
!
evpn ethernet-segment
identifier 0022:2222:2222:2222:2222
mpls shared index 100 <<--- shared ESI index
route-target import 00:02:00:02:00:02

EOS TOI:
https://eos.arista.com/eos-4-25-2f/l2-evpn-mpls-shared-esi-label/

[UchihaItachiSama]

Hi Himanshu!
From EVPN-VXLAN perspective looks good to me. However, for EVPN-MPLS MH I would recommend to add followig knob to cli_config_gen:
interface Ethernet4
switchport access vlan 1000
!
evpn ethernet-segment
identifier 0022:2222:2222:2222:2222
mpls shared index 100 <<--- shared ESI index
route-target import 00:02:00:02:00:02

EOS TOI:
https://eos.arista.com/eos-4-25-2f/l2-evpn-mpls-shared-esi-label/

Hey Leonid,

Sure, i'll check the TOI and update the data model as follows:

    evpn_ethernet_segment:
      redundancy: < Multihoming redundancy mode (all-active | single-active | default --> all-active) >
      designated_forwarder_election:
        algorithm: < modulus | preference | default --> modulus >
        preference_value: < Preference value (0-65535) >
        dont_preempt: < non-revertive DF election mode ( true | false | default --> false ) >
        hold_time: < time seconds (1-1800) >
        subsequent_hold_time: < time milliseconds (10-10000) >
        candidate_reachability_required: < true | false | default --> false >
        mpls_shared_index: < (1-1024) >
        

[UchihaItachiSama]

Updated the requested changes.

[tgodaA]

Hi, FYI, here is a PR that is closely related to your's: #1437. Forget about the esi/identifier, and rt/route_target. But you can implement rest of the knobs similarly.

[github-actions]

This pull request has conflicts, please resolve those before we can evaluate the pull request.

[tgodaA]

Hi Himanshu. Do you want me to take this PR? I have a requirement of this feature, not immediately but by next month. We have lot of time but let me know if you want me to take this. I did something similar tho this feature on ethernet-interfaces, #1437

[UchihaItachiSama]

Hey Tony, sure. sorry got a bit backed up on other work.

[github-actions]

Conflicts have been resolved. A maintainer will review the pull request shortly.

[ClausHolbechArista]

LGTM

[carlbuchmann]

LGTM!