Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix(dhcp_provisioner): Fix lease_time & role doc update #1431

Merged
merged 5 commits into from
Jan 12, 2022
Merged

Fix(dhcp_provisioner): Fix lease_time & role doc update #1431

merged 5 commits into from
Jan 12, 2022

Conversation

titom73
Copy link
Contributor

@titom73 titom73 commented Jan 6, 2022

Change Summary

Related Issue(s)

N/A

Component(s) name

arista.avd.dhcp_provisioner

Proposed changes

  • Add relation with cvp_instance_ip(s) in documentation
  • Fix lease_time & CV IP logic

How to test

N/A

Checklist

User Checklist

  • N/A

Repository Checklist

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and documentation have been updated accordingly.
  • I have updated molecule CI testing accordingly. (check the box if not applicable)

tgodaA
tgodaA approved these changes Jan 12, 2022
View reviewed changes
Copy link
Contributor

@tgodaA tgodaA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

noredistribution
noredistribution approved these changes Jan 12, 2022
View reviewed changes
Copy link
Contributor

@noredistribution noredistribution left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM too!

@titom73 titom73 changed the title Fix(dhcp_provisioner): Fix lease_time + role documentation update Fix(dhcp_provisioner): Fix lease_time & role doc update Jan 12, 2022
@titom73 titom73 merged commit f47257d into aristanetworks:devel Jan 12, 2022
@titom73 titom73 deleted the fix/dhcp-provisioner branch January 12, 2022 15:24
@ClausHolbechArista ClausHolbechArista linked an issue Jan 13, 2022 that may be closed by this pull request
Missing " cvp_instance_ips" from roles documentation "dhcp_provisioner" #1256
Closed
@ClausHolbechArista ClausHolbechArista mentioned this pull request Jan 13, 2022
Closed
@ClausHolbechArista ClausHolbechArista added this to the v3.3.0 milestone Feb 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tgodaA tgodaA tgodaA approved these changes

@guillaumeVilar guillaumeVilar Awaiting requested review from guillaumeVilar

@noredistribution noredistribution Awaiting requested review from noredistribution

Assignees

@titom73 titom73

Labels
role: dhcp_provisioner state: Documentation role Updated
Projects
None yet
Milestone
v3.3.0
Development

Successfully merging this pull request may close these issues.

Missing " cvp_instance_ips" from roles documentation "dhcp_provisioner"
4 participants
@titom73 @noredistribution @tgodaA @ClausHolbechArista