Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Fix yaml-lint issues #1433

Merged
merged 1 commit into from
Jan 12, 2022
Merged

Conversation

tgodaA
Copy link
Contributor

@tgodaA tgodaA commented Jan 11, 2022

Change Summary

The PR #1430 was introduced recently for the yaml-lint checking. Other PR #1410 wasn't rebased after #1430 was merged into devel. And PR #1410 has some yaml-lint issues (ssh-key size > 350 chars) and this issue was missed as this PR wasn't rebased before merging into devel.

In the current PR, the ssh-key size was reduced to < 350 characters to fix the yaml-lint issues.

Proposed changes

How to test

Checklist

User Checklist

  • N/A

Repository Checklist

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and documentation have been updated accordingly.
  • I have updated molecule CI testing accordingly. (check the box if not applicable)

@github-actions github-actions bot requested a review from titom73 January 11, 2022 20:17
@github-actions github-actions bot added the state: CI Updated CI scenario have been updated in the PR label Jan 11, 2022
Copy link
Contributor

@ClausHolbechArista ClausHolbechArista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@carlbuchmann carlbuchmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@carlbuchmann carlbuchmann merged commit 8a2f66b into aristanetworks:devel Jan 12, 2022
@tgodaA tgodaA deleted the fix_lint branch January 14, 2022 02:43
@ClausHolbechArista ClausHolbechArista added this to the v3.3.0 milestone Feb 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
state: CI Updated CI scenario have been updated in the PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants