Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Linting errors with upper-case variables #1443

Merged
merged 3 commits into from
Jan 24, 2022
Merged

Fix: Linting errors with upper-case variables #1443

merged 3 commits into from
Jan 24, 2022

Conversation

emilarista
Copy link
Contributor

Change Summary

Fixes patch panel doc template to not use capital letters in j2 variables.

Component(s) name

arista.avd.eos_cli_config_gen

Repository Checklist

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and documentation have been updated accordingly.
  • I have updated molecule CI testing accordingly. (check the box if not applicable)

@github-actions github-actions bot added role: eos_cli_config_gen issue related to eos_cli_config_gen role state: CI Updated CI scenario have been updated in the PR labels Jan 19, 2022
@emilarista emilarista changed the title BugFix(eos_cli_config_gen): Remove Capital Letters from Patch Panel doc template j2 variables Refactor(eos_cli_config_gen): Remove Capital Letters from Patch Panel doc template j2 variables Jan 19, 2022
ClausHolbechArista
ClausHolbechArista requested changes Jan 19, 2022
View reviewed changes
Copy link
Contributor

@ClausHolbechArista ClausHolbechArista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. We will hold this PR back until we have merged the J2lint. Then we need to enable the j2lint for lower case variables as part of this PR.

@carlbuchmann carlbuchmann force-pushed the fix_patch_panel branch 2 times, most recently from 8e6e7e9 to 1beed28 Compare January 21, 2022 02:06
carlbuchmann
carlbuchmann approved these changes Jan 21, 2022
View reviewed changes
Copy link
Member

@carlbuchmann carlbuchmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@github-actions github-actions bot added the type: code quality CI and development toolset label Jan 21, 2022
@github-actions github-actions bot added role: eos_designs issue related to eos_designs role role: eos_validate_state labels Jan 24, 2022
@ClausHolbechArista ClausHolbechArista changed the title Refactor(eos_cli_config_gen): Remove Capital Letters from Patch Panel doc template j2 variables Fix: Linting errors with upper-case variables Jan 24, 2022
ClausHolbechArista
ClausHolbechArista approved these changes Jan 24, 2022
View reviewed changes
Copy link
Contributor

@ClausHolbechArista ClausHolbechArista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ClausHolbechArista ClausHolbechArista merged commit 71fb01f into aristanetworks:devel Jan 24, 2022
@ClausHolbechArista ClausHolbechArista added this to the v3.3.0 milestone Feb 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ClausHolbechArista ClausHolbechArista ClausHolbechArista approved these changes

@onurgashi onurgashi Awaiting requested review from onurgashi

@titom73 titom73 Awaiting requested review from titom73

@aphillipps aphillipps Awaiting requested review from aphillipps

@carlbuchmann carlbuchmann Awaiting requested review from carlbuchmann

@ankudinov ankudinov Awaiting requested review from ankudinov

@ksator ksator Awaiting requested review from ksator

Assignees

@emilarista emilarista

Labels
role: eos_cli_config_gen issue related to eos_cli_config_gen role role: eos_designs issue related to eos_designs role role: eos_validate_state state: CI Updated CI scenario have been updated in the PR type: code quality CI and development toolset
Projects
None yet
Milestone
v3.3.0
Development

Successfully merging this pull request may close these issues.
3 participants
@emilarista @carlbuchmann @ClausHolbechArista